Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: chrome/browser/ui/views/menu_test_base.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/menu_test_base.cc
diff --git a/chrome/browser/ui/views/menu_test_base.cc b/chrome/browser/ui/views/menu_test_base.cc
index f7b5aa919284588941e6f4bcb7138b9c2ae9eae6..b44d2f8772fc59be85b640045cfa666ba1605478 100644
--- a/chrome/browser/ui/views/menu_test_base.cc
+++ b/chrome/browser/ui/views/menu_test_base.cc
@@ -38,7 +38,7 @@ void MenuTestBase::KeyPress(ui::KeyboardCode keycode,
}
int MenuTestBase::GetMenuRunnerFlags() {
- return views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::ASYNC;
+ return views::MenuRunner::HAS_MNEMONICS;
}
void MenuTestBase::SetUp() {
@@ -79,11 +79,8 @@ void MenuTestBase::OnMenuButtonClicked(views::MenuButton* source,
gfx::Point screen_location;
views::View::ConvertPointToScreen(source, &screen_location);
gfx::Rect bounds(screen_location, source->size());
- ignore_result(menu_runner_->RunMenuAt(source->GetWidget(),
- button_,
- bounds,
- views::MENU_ANCHOR_TOPLEFT,
- ui::MENU_SOURCE_NONE));
+ menu_runner_->RunMenuAt(source->GetWidget(), button_, bounds,
+ views::MENU_ANCHOR_TOPLEFT, ui::MENU_SOURCE_NONE);
}
void MenuTestBase::ExecuteCommand(int id) {
« no previous file with comments | « chrome/browser/ui/views/menu_model_adapter_test.cc ('k') | chrome/browser/ui/views/menu_view_drag_and_drop_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698