chrome/browser/ui/views/frame/browser_frame.cc - Issue 2790773002: Cleanup MenuRunner API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_frame.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_frame.cc

diff --git a/chrome/browser/ui/views/frame/browser_frame.cc b/chrome/browser/ui/views/frame/browser_frame.cc

index 0df995091cf21e7923dac9a47c1854443689468a..14d7bbf8f3d0b2bb8c849ce6c81fd94e732f2c81 100644

--- a/chrome/browser/ui/views/frame/browser_frame.cc

+++ b/chrome/browser/ui/views/frame/browser_frame.cc

@@ -250,8 +250,7 @@ void BrowserFrame::ShowContextMenuForView(views::View* source,

if (hit_test == HTCAPTION || hit_test == HTNOWHERE) {

menu_runner_.reset(new views::MenuRunner(

GetSystemMenuModel(),

- views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::CONTEXT_MENU |

- views::MenuRunner::ASYNC,

+ views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::CONTEXT_MENU,

base::Bind(&BrowserFrame::OnMenuClosed, base::Unretained(this))));

menu_runner_->RunMenuAt(source->GetWidget(), nullptr,

gfx::Rect(p, gfx::Size(0, 0)),