chrome/browser/ui/views/download/download_shelf_context_menu_view.cc - Issue 2790773002: Cleanup MenuRunner API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc ('k') | chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

diff --git a/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc b/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

index 7ada929e759981804e43d9643627c0feea35ab27..2c9b4c88c22f6c8e2fa1d33515d5e50df956f531 100644

--- a/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

+++ b/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

@@ -30,8 +30,7 @@ void DownloadShelfContextMenuView::Run(

menu_runner_.reset(new views::MenuRunner(

menu_model,

- views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::CONTEXT_MENU |

- views::MenuRunner::ASYNC,

+ views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::CONTEXT_MENU,

base::Bind(&DownloadShelfContextMenuView::OnMenuClosed,

base::Unretained(this), on_menu_closed_callback)));