Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc
index e6ce22e1e6567dd6e122e38867bd22d1b0bd1dc1..cd2b00e3ec3c1ec26be71c38f03f43e90ee1ae80 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc
@@ -54,8 +54,7 @@ BookmarkContextMenu::BookmarkContextMenu(
menu_runner_(new views::MenuRunner(menu_,
views::MenuRunner::HAS_MNEMONICS |
views::MenuRunner::IS_NESTED |
- views::MenuRunner::CONTEXT_MENU |
- views::MenuRunner::ASYNC)),
+ views::MenuRunner::CONTEXT_MENU)),
observer_(NULL),
close_on_remove_(close_on_remove) {
ui::SimpleMenuModel* menu_model = controller_->menu_model();
@@ -110,8 +109,7 @@ bool BookmarkContextMenu::ShouldCloseAllMenusOnExecute(int id) {
return (id != IDC_BOOKMARK_BAR_REMOVE) || close_on_remove_;
}
-void BookmarkContextMenu::OnMenuClosed(views::MenuItemView* menu,
- views::MenuRunner::RunResult result) {
+void BookmarkContextMenu::OnMenuClosed(views::MenuItemView* menu) {
if (observer_)
observer_->OnContextMenuClosed();
}
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_context_menu.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698