Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Side by Side Diff: chrome/browser/ui/views/menu_view_drag_and_drop_test.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "chrome/browser/ui/views/menu_test_base.h" 7 #include "chrome/browser/ui/views/menu_test_base.h"
8 #include "chrome/test/base/interactive_test_utils.h" 8 #include "chrome/test/base/interactive_test_utils.h"
9 #include "ui/base/dragdrop/drag_drop_types.h" 9 #include "ui/base/dragdrop/drag_drop_types.h"
10 #include "ui/base/dragdrop/os_exchange_data.h" 10 #include "ui/base/dragdrop/os_exchange_data.h"
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 ~MenuViewDragAndDropForDropStayOpen() override {} 456 ~MenuViewDragAndDropForDropStayOpen() override {}
457 457
458 private: 458 private:
459 // MenuViewDragAndDropTest: 459 // MenuViewDragAndDropTest:
460 int GetMenuRunnerFlags() override; 460 int GetMenuRunnerFlags() override;
461 void DoTestWithMenuOpen() override; 461 void DoTestWithMenuOpen() override;
462 }; 462 };
463 463
464 int MenuViewDragAndDropForDropStayOpen::GetMenuRunnerFlags() { 464 int MenuViewDragAndDropForDropStayOpen::GetMenuRunnerFlags() {
465 return views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::NESTED_DRAG | 465 return views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::NESTED_DRAG |
466 views::MenuRunner::FOR_DROP | views::MenuRunner::ASYNC; 466 views::MenuRunner::FOR_DROP;
467 } 467 }
468 468
469 void MenuViewDragAndDropForDropStayOpen::DoTestWithMenuOpen() { 469 void MenuViewDragAndDropForDropStayOpen::DoTestWithMenuOpen() {
470 views::SubmenuView* submenu = menu()->GetSubmenu(); 470 views::SubmenuView* submenu = menu()->GetSubmenu();
471 ASSERT_TRUE(submenu); 471 ASSERT_TRUE(submenu);
472 ASSERT_TRUE(submenu->IsShowing()); 472 ASSERT_TRUE(submenu->IsShowing());
473 473
474 views::MenuController* controller = menu()->GetMenuController(); 474 views::MenuController* controller = menu()->GetMenuController();
475 ASSERT_TRUE(controller); 475 ASSERT_TRUE(controller);
476 EXPECT_FALSE(controller->IsCancelAllTimerRunningForTest()); 476 EXPECT_FALSE(controller->IsCancelAllTimerRunningForTest());
(...skipping 11 matching lines...) Expand all
488 MenuViewDragAndDropForDropCancel() {} 488 MenuViewDragAndDropForDropCancel() {}
489 ~MenuViewDragAndDropForDropCancel() override {} 489 ~MenuViewDragAndDropForDropCancel() override {}
490 490
491 private: 491 private:
492 // MenuViewDragAndDropTest: 492 // MenuViewDragAndDropTest:
493 int GetMenuRunnerFlags() override; 493 int GetMenuRunnerFlags() override;
494 void DoTestWithMenuOpen() override; 494 void DoTestWithMenuOpen() override;
495 }; 495 };
496 496
497 int MenuViewDragAndDropForDropCancel::GetMenuRunnerFlags() { 497 int MenuViewDragAndDropForDropCancel::GetMenuRunnerFlags() {
498 return views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::FOR_DROP | 498 return views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::FOR_DROP;
499 views::MenuRunner::ASYNC;
500 } 499 }
501 500
502 void MenuViewDragAndDropForDropCancel::DoTestWithMenuOpen() { 501 void MenuViewDragAndDropForDropCancel::DoTestWithMenuOpen() {
503 views::SubmenuView* submenu = menu()->GetSubmenu(); 502 views::SubmenuView* submenu = menu()->GetSubmenu();
504 ASSERT_TRUE(submenu); 503 ASSERT_TRUE(submenu);
505 ASSERT_TRUE(submenu->IsShowing()); 504 ASSERT_TRUE(submenu->IsShowing());
506 505
507 views::MenuController* controller = menu()->GetMenuController(); 506 views::MenuController* controller = menu()->GetMenuController();
508 ASSERT_TRUE(controller); 507 ASSERT_TRUE(controller);
509 EXPECT_TRUE(controller->IsCancelAllTimerRunningForTest()); 508 EXPECT_TRUE(controller->IsCancelAllTimerRunningForTest());
510 509
511 Done(); 510 Done();
512 } 511 }
513 512
514 // Test that if a menu is opened for a drop handled entirely by menu code, the 513 // Test that if a menu is opened for a drop handled entirely by menu code, the
515 // menu will try to close if it does not receive any drag updates. 514 // menu will try to close if it does not receive any drag updates.
516 // If this flakes, disable and log details in http://crbug.com/523255. 515 // If this flakes, disable and log details in http://crbug.com/523255.
517 VIEW_TEST(MenuViewDragAndDropForDropCancel, MenuViewCancelsForOwnDrag) 516 VIEW_TEST(MenuViewDragAndDropForDropCancel, MenuViewCancelsForOwnDrag)
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/menu_test_base.cc ('k') | chrome/browser/ui/views/page_info/permission_selector_row.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698