Add a function triggering extension installed to ExtensionRegistryObserver

extensions/browser/extension_registry.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_registry.h"
 
 #include "base/strings/string_util.h"
 #include "extensions/browser/extension_registry_factory.h"
 #include "extensions/browser/extension_registry_observer.h"
 
@@ skipping 35 matching lines @@
 
 void ExtensionRegistry::TriggerOnUnloaded(
     const Extension* extension,
     UnloadedExtensionInfo::Reason reason) {
   DCHECK(!enabled_extensions_.Contains(extension->id()));
   FOR_EACH_OBSERVER(ExtensionRegistryObserver,
                     observers_,
                     OnExtensionUnloaded(browser_context_, extension, reason));
 }
 
+void ExtensionRegistry::TriggerOnWillBeInstalled(const Extension* extension,
+                                                 bool is_update,
+                                                 const std::string& old_name) {

[not at google - send to devlin, 2014/05/20 18:27:12]

I think the DCHECK actually was right and the unit test was wrong. If it's an
update then a new extension should have been generated.

But the DCHECK was wrong in that there should be an extension with that *id*
already installed, depending on the value of |is_update|.

[limasdf, 2014/05/21 15:35:08]

Done. yeah exactly should do DCHECK depending on |is_update|.

+  FOR_EACH_OBSERVER(ExtensionRegistryObserver,
+                    observers_,
+                    OnExtensionWillBeInstalled(
+                        browser_context_, extension, is_update, old_name));
+}
+
 const Extension* ExtensionRegistry::GetExtensionById(const std::string& id,
                                                      int include_mask) const {
   std::string lowercase_id = StringToLowerASCII(id);
   if (include_mask & ENABLED) {
     const Extension* extension = enabled_extensions_.GetByID(lowercase_id);
     if (extension)
       return extension;
   }
   if (include_mask & DISABLED) {
     const Extension* extension = disabled_extensions_.GetByID(lowercase_id);
@@ skipping 60 matching lines @@
     const ExtensionSet::ModificationCallback& callback) {
   disabled_extensions_.set_modification_callback(callback);
 }
 
 void ExtensionRegistry::Shutdown() {
   // Release references to all Extension objects in the sets.
   ClearAll();
 }
 
 }  // namespace extensions