Add a function triggering extension installed to ExtensionRegistryObserver

extensions/browser/extension_registry_observer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_EXTENSION_REGISTRY_OBSERVER_H_
 #define EXTENSIONS_BROWSER_EXTENSION_REGISTRY_OBSERVER_H_
 
 #include "extensions/common/extension.h"
 
 namespace content {
@@ skipping 15 matching lines @@
   // in the enabled_extensions set of ExtensionRegistry.
   virtual void OnExtensionLoaded(
       content::BrowserContext* browser_context,
       const Extension* extension) {}
 
   // Called after an extension is unloaded. The extension no longer exists in
   // any of the ExtensionRegistry sets (enabled, disabled, etc.).
   virtual void OnExtensionUnloaded(content::BrowserContext* browser_context,
                                    const Extension* extension,
                                    UnloadedExtensionInfo::Reason reason) {}
+
+  // Called after an extension is installed. The extension will be in exactly
+  // one of the ExtensionRegistry sets.

[not at google - send to devlin, 2014/05/16 13:49:03]

This comment which I asked you to write is actually incorrect, right? The
extension will be in NONE of the ExtensionRegistry sets (based on your DCHECK in
TriggerOnInstalled and reading the code in ExtensionService).

Like I mentioned there, that's a really weird contract, particularly given the
name.

The best idea I've come up with so far (like I mentioned) is to call this
OnExtensionWillBeInstalled, and in the comment emphasize
- the extension won't be in the registry
- the extension is about to appear in the registry (but could be in any of the
sets)
- callers probably want to listen for OnLoaded unless they really do want to
know when an extension is about to be installed.

[limasdf, 2014/05/16 20:39:14]

Yep, ExtensionService send notification prior to actual end of install.
(from here, the notification of NOTIFICATION_EXTENSION_INSTALLED is also
incorrect, isn't it? I think it also should be 
NOTIFICATION_EXTENSION_WILLBEINSTALLED)

[not at google - send to devlin, 2014/05/16 23:03:35]

yes exactly. I expect at least one person has been confused by this over the
years...

+  virtual void OnExtensionInstalled(content::BrowserContext* browser_context,
+                                    const Extension* extension,
+                                    bool is_update,
+                                    const std::string& old_name) {}
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_EXTENSION_REGISTRY_OBSERVER_H_