chrome/browser/ui/views/dialog_uma/dialog_uma.h - Issue 2790723004: Function to count dialog box creations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/dialog_uma/dialog_uma.h

Issue 2790723004: Function to count dialog box creations. (Closed)

Patch Set: format Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_
	msw 2017/04/05 00:26:54 A couple questions: (1) Why is this specific to vi A couple questions: (1) Why is this specific to views? (seems viable for Mac/Android/iOS too) (2) Why create the dialog_uma subdir? (seems unnecessary for two files) pdyson 2017/04/05 03:43:24 (1) This is to enable DPM (decisions per thousand) Show quoted text On 2017/04/05 at 00:26:54, msw wrote: > A couple questions: > (1) Why is this specific to views? (seems viable for Mac/Android/iOS too) > (2) Why create the dialog_uma subdir? (seems unnecessary for two files) (1) This is to enable DPM (decisions per thousand) to be measured. DPM already has good coverage for InfoBars on Android and iOS using UMA metric InfoBar.Shown. This CL is to start adding coverage for Dialog Boxes on Windows/Linux (and Mac when it moves to views). So I think that makes Views the appropriate place, but I'm quite new to the Chrome code base. (2) I'm open to ideas on where this should go. How about chrome/browser/ui/views/dialog_uma.h? msw 2017/04/05 04:32:12 Is there a reason that this shouldn't support Coco Show quoted text On 2017/04/05 03:43:24, pdyson wrote: > On 2017/04/05 at 00:26:54, msw wrote: > > A couple questions: > > (1) Why is this specific to views? (seems viable for Mac/Android/iOS too) > > (2) Why create the dialog_uma subdir? (seems unnecessary for two files) > > (1) This is to enable DPM (decisions per thousand) to be measured. DPM > already has good coverage for InfoBars on Android and iOS using UMA > metric InfoBar.Shown. This CL is to start adding coverage for Dialog > Boxes on Windows/Linux (and Mac when it moves to views). So I think > that makes Views the appropriate place, but I'm quite new to the Chrome > code base. Is there a reason that this shouldn't support Cocoa in the interim on Mac? Show quoted text > (2) I'm open to ideas on where this should go. How about > chrome/browser/ui/views/dialog_uma.h? That would be better, if it should be views-specific. Or I'd suggest: chrome/browser/ui/browser_dialogs.h (and a new *.cc)
	6 #define CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_

	7

	8 // Values used in the Dialog.Creation UMA metric. Each value represents a

	9 // different type of dialog box.

	10 // These values are written to logs. New enum values can be added, but existing

	11 // enums must never be renumbered or deleted and reused.

	12 enum class DialogIdentifier { UNKNOWN = 0, TRANSLATE = 1, MAX_VALUE };

	13

	14 // Record an UMA metric counting the creation of a dialog box of this type.

	15 void RecordDialogCreation(DialogIdentifier identifier);

	16

	17 #endif // CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_

OLD	NEW

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/views/dialog_uma/dialog_uma.cc » ('j') | no next file with comments »