Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #ifndef CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_ | |
| 6 #define CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_ | |
| 7 | |
| 8 // Values used in the Dialog.Creation UMA metric. Each value represents a | |
| 9 // different type of dialog box. | |
| 10 // These values are written to logs. New enum values can be added, but existing | |
| 11 // enums must never be renumbered or deleted and reused. | |
| 12 enum class DialogIdentifier { | |
| 13 UNKNOWN = 0, | |
| 14 TRANSLATE = 1, | |
| 15 MAX_VALUE = 2, | |
|
tapted
2017/04/04 04:18:06
This should drop the `= 2` and the trailing comma.
pdyson
2017/04/04 04:29:53
I see. Done.
With those changes "git cl format" p
| |
| 16 }; | |
| 17 | |
| 18 // Record an UMA metric counting the creation of a dialog box of this type. | |
| 19 void RecordDialogCreation(DialogIdentifier identifier); | |
| 20 | |
| 21 #endif // CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_ | |
| OLD | NEW |