Chromium Code Reviews Chromium Code Reviews
Issue 2790693002:
Split CSP into pre- and post-upgrade checks (Closed)
| Index: third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/upgrade-insecure-requests-reporting.https.html |
| diff --git a/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/upgrade-insecure-requests-reporting.https.html b/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/upgrade-insecure-requests-reporting.https.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..8abea804997ae9b1461984b4c3342c5d76f9b771 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/securitypolicyviolation/upgrade-insecure-requests-reporting.https.html |
| @@ -0,0 +1,35 @@ |
| +<!doctype html> |
| +<script src="/resources/testharness.js"></script> |
| +<script src="/resources/testharnessreport.js"></script> |
| +<script src="/upgrade-insecure-requests/support/testharness-helper.sub.js"></script> |
| +<body> |
| +<script> |
| + function waitForViolation(el) { |
| + return new Promise(resolve => { |
| + el.addEventListener('securitypolicyviolation', e => resolve(e)); |
| + }); |
| + } |
| + |
| + async_test(t => { |
| + var url = generateURL(Host.SAME_ORIGIN, Protocol.INSECURE, ResourceType.IMAGE).url; |
| + var i = document.createElement('img'); |
| + var loaded = false; |
|
estark
2017/04/12 01:35:19
surely there is some nicer way to write a test wit
Mike West
2017/04/12 13:31:36
You'd think so. But you have to build it yourself.
estark
2017/04/13 01:42:18
Acknowledged.
|
| + var reported = false; |
| + waitForViolation(window) |
| + .then(t.step_func(e => { |
| + assert_equals(e.blockedURI, url); |
| + reported = true; |
| + if (loaded) |
| + t.done(); |
| + })); |
| + i.onload = t.step_func(_ => { |
| + assert_equals(i.naturalHeight, 64, "Height."); |
| + assert_equals(i.naturalWidth, 168, "Width."); |
|
Mike West
2017/04/12 13:31:36
Best to drop these comparisons. Andy found that WP
estark
2017/04/13 01:42:17
Done.
|
| + loaded = true; |
| + if (reported) |
| + t.done(); |
| + }); |
| + i.onerror = t.unreached_func(url + " should load successfully."); |
| + i.src = url; |
| + }, "Upgraded image is reported"); |
|
Mike West
2017/04/12 13:31:36
Can you add an iframe check as well? Some of that
estark
2017/04/13 01:42:18
I have learned many exciting things:
- I added an
|
| +</script> |
