Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2790673004: DartVM: Fix rounding error causing linear instead of geometric heap growth (Closed)

Created:
3 years, 8 months ago by erikcorry
Modified:
3 years, 8 months ago
Reviewers:
siva, kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DartVM: Fix rounding error causing linear instead of geometric heap growth R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c5ffe748815722641cb540edc385c7f76e1de816

Patch Set 1 #

Patch Set 2 : Remove inadvertent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/vm/pages.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
erikcorry
3 years, 8 months ago (2017-03-31 09:11:17 UTC) #1
kustermann
LGTM, nice catch!
3 years, 8 months ago (2017-03-31 09:20:52 UTC) #2
erikcorry
Committed patchset #2 (id:20001) manually as c5ffe748815722641cb540edc385c7f76e1de816 (presubmit successful).
3 years, 8 months ago (2017-03-31 09:21:43 UTC) #4
siva
3 years, 8 months ago (2017-03-31 17:06:39 UTC) #6
Message was sent while issue was closed. 
Nice catch.

Powered by Google App Engine
This is Rietveld 408576698