Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 279063002: Revert of Some refactorings to facilitate a larger change to TemplateURLService. (Closed)

Created:
6 years, 7 months ago by Alpha Left Google
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Some refactorings to facilitate a larger change to TemplateURLService. (https://codereview.chromium.org/270533007/) Reason for revert: See memory failure: bot: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/759/steps/unit_tests/logs/stdio Original issue's description: > Some refactorings to facilitate a larger change to TemplateURLService. > > BUG=365762 > R=pkasting@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269310 TBR=pkasting@chromium.org,erikwright@chromium.org NOTREECHECKS=true NOTRY=true BUG=365762 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -57 lines) Patch
M chrome/browser/search_engines/default_search_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/default_search_pref_migration.cc View 1 chunk +46 lines, -35 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alpha Left Google
Created Revert of Some refactorings to facilitate a larger change to TemplateURLService.
6 years, 7 months ago (2014-05-10 21:13:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/279063002/1
6 years, 7 months ago (2014-05-10 21:14:49 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 21:16:25 UTC) #3
Message was sent while issue was closed.
Change committed as 269638

Powered by Google App Engine
This is Rietveld 408576698