Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2232)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Issue 2790603003: Make CUPS USB printing play better with the settings page. This change does several things: (Closed)
Patch Set: Address xdai@ comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
index eede8a01bce092946c4e98105daeb349315fb6c8..4f139b2ce025541eb8a4f66e10338f9838d73dc7 100644
--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
@@ -49,7 +49,7 @@
<div class="dialog-title">$i18n{addPrintersNearbyTitle}</div>
<div class="dialog-body">
<add-printer-list printers="[[discoveredPrinters]]"
- selected-printer="{{selectedPrinter}}">
+ new-printer="{{newPrinter}}">
stevenjb 2017/04/10 19:49:55 previous indent was correct
Carlson 2017/04/10 22:16:42 Removed from this changelist
</add-printer-list>
<div class="center" id="noPrinterMessage" hidden>
$i18n{noPrinterNearbyMessage}
@@ -68,7 +68,7 @@
$i18n{cancelButtonText}
</paper-button>
<paper-button class="action-button" id="addPrinterButton"
- disabled="[[!selectedPrinter]]" on-tap="switchToConfiguringDialog_">
+ disabled="[[!newPrinter]]" on-tap="switchToManufacturerDialog_">
$i18n{addPrinterButtonText}
</paper-button>
</div>
@@ -348,7 +348,7 @@
<!-- Printer Discovery Dialog -->
<template is="dom-if" if="[[showDiscoveryDialog_]]" restamp>
- <add-printer-discovery-dialog selected-printer="{{selectedPrinter}}">
+ <add-printer-discovery-dialog new-printer="{{newPrinter}}">
</add-printer-discovery-dialog>
</template>

Powered by Google App Engine
This is Rietveld 408576698