chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html - Issue 2790603003: Make CUPS USB printing play better with the settings page. This change does several things:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Issue 2790603003: Make CUPS USB printing play better with the settings page. This change does several things: (Closed)

Patch Set: Pre-review cleanups Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/printing/printer_discoverer.cc ('K') | « chrome/browser/chromeos/printing/printers_manager.h ('k') | chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

index 0517ba187deceb5382882870ce06978c9ac74f92..b0d82f0dd06b42feec19d58cb20cebb22b68c2f6 100644

--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

@@ -49,7 +49,7 @@

<div class="dialog-title">$i18n{addPrintersNearbyTitle}</div>

<add-printer-list printers="[[discoveredPrinters]]"

- selected-printer="{{selectedPrinter}}">

+ new-printer="{{newPrinter}}">

</add-printer-list>

$i18n{noPrinterNearbyMessage}

@@ -68,7 +68,7 @@

$i18n{cancelButtonText}

</paper-button>

<paper-button class="action-button" id="addPrinterButton"

- disabled="[[!selectedPrinter]]" on-tap="switchToConfiguringDialog_">

+ disabled="[[!newPrinter]]" on-tap="switchToManufacturerDialog_">

$i18n{addPrinterButtonText}

</paper-button>

</div>

@@ -348,7 +348,7 @@

- <add-printer-discovery-dialog selected-printer="{{selectedPrinter}}">

+ <add-printer-discovery-dialog new-printer="{{newPrinter}}">

</add-printer-discovery-dialog>

</template>