Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Issue 2790603003: Make CUPS USB printing play better with the settings page. This change does several things: (Closed)
Patch Set: stop latching PrintersManager, add comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_CUPS_PRINTERS_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_CUPS_PRINTERS_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_CUPS_PRINTERS_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_CUPS_PRINTERS_HANDLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 // ui::SelectFileDialog::Listener override: 81 // ui::SelectFileDialog::Listener override:
82 void FileSelected(const base::FilePath& path, 82 void FileSelected(const base::FilePath& path,
83 int index, 83 int index,
84 void* params) override; 84 void* params) override;
85 85
86 void HandleStartDiscovery(const base::ListValue* args); 86 void HandleStartDiscovery(const base::ListValue* args);
87 void HandleStopDiscovery(const base::ListValue* args); 87 void HandleStopDiscovery(const base::ListValue* args);
88 88
89 // chromeos::PrinterDiscoverer::Observer override: 89 // chromeos::PrinterDiscoverer::Observer override:
90 void OnPrintersFound(const std::vector<Printer>& printers) override; 90 void OnPrintersFound(const std::vector<Printer>& printers) override;
91 void OnDiscoveryDone() override; 91 void OnDiscoveryInitialScanDone() override;
92 92
93 // Invokes debugd to add the printer to CUPS. If |ipp_everywhere| is true, 93 // Invokes debugd to add the printer to CUPS. If |ipp_everywhere| is true,
94 // automatic configuration will be attempted and |ppd_path| is ignored. 94 // automatic configuration will be attempted and |ppd_path| is ignored.
95 // |ppd_path| is the path to a Postscript Printer Description file that will 95 // |ppd_path| is the path to a Postscript Printer Description file that will
96 // be used to configure the printer capabilities. This file must be in 96 // be used to configure the printer capabilities. This file must be in
97 // Downloads or the PPD Cache. 97 // Downloads or the PPD Cache.
98 void AddPrinterToCups(std::unique_ptr<Printer> printer, 98 void AddPrinterToCups(std::unique_ptr<Printer> printer,
99 const base::FilePath& ppd_path, 99 const base::FilePath& ppd_path,
100 bool ipp_everywhere); 100 bool ipp_everywhere);
101 101
(...skipping 12 matching lines...) Expand all
114 114
115 base::WeakPtrFactory<CupsPrintersHandler> weak_factory_; 115 base::WeakPtrFactory<CupsPrintersHandler> weak_factory_;
116 116
117 DISALLOW_COPY_AND_ASSIGN(CupsPrintersHandler); 117 DISALLOW_COPY_AND_ASSIGN(CupsPrintersHandler);
118 }; 118 };
119 119
120 } // namespace settings 120 } // namespace settings
121 } // namespace chromeos 121 } // namespace chromeos
122 122
123 #endif // CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_CUPS_PRINTERS_HANDLER_H_ 123 #endif // CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_CUPS_PRINTERS_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698