Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/benchmarks/media.py

Issue 2790493008: Disable media.android.tvc_tbmv2 on most devices (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/media.py
diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py
index 557d0796dcb392c380f796115e318214c58c4abd..19866bf0101aefc40d756cb5c45c52a5cb7fddda 100644
--- a/tools/perf/benchmarks/media.py
+++ b/tools/perf/benchmarks/media.py
@@ -142,7 +142,10 @@ class MediaAndroidToughVideoCasesTBMv2(_MediaTBMv2Benchmark):
@classmethod
def ShouldDisable(cls, possible_browser):
- return cls.IsSvelte(possible_browser)
+ # This benchmark is having issues with devices other than Nexus 5X.
+ # Disabling on those devices until we figure out the cause.
CalebRouleau 2017/03/31 23:04:45 Add a link to the crbug for this.
+ return (cls.IsSvelte(possible_browser) or
+ possible_browser.platform.GetDeviceTypeName() != 'Nexus 5X')
@classmethod
def Name(cls):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698