Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: recipe_engine/autoroll.py

Issue 2790493007: test: promote --train to its own subcommand (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | recipe_engine/test.py » ('j') | recipe_engine/test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_engine/autoroll.py
diff --git a/recipe_engine/autoroll.py b/recipe_engine/autoroll.py
index 15e3a08b6e55adb0693f82fd01e82a6e06c936bd..eace33338b1ffc24ef409cf2bb308137f84e7ddc 100644
--- a/recipe_engine/autoroll.py
+++ b/recipe_engine/autoroll.py
@@ -131,7 +131,7 @@ def run_simulation_test(repo_root, package_spec, additional_args=None,
]
if not allow_fetch:
args.append('--no-fetch')
- args.extend(['test', 'run'])
+ args.append('test')
if additional_args:
args.extend(additional_args)
p = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
@@ -169,7 +169,7 @@ def process_candidates(candidates, context, config_file, package_spec):
fetch(context.repo_root, package_spec)
write_new_recipes_py(context, spec, repo_cfg_block)
- rc, output = run_simulation_test(context.repo_root, package_spec)
+ rc, output = run_simulation_test(context.repo_root, package_spec, ['run'])
roll_details[i]['recipes_simulation_test'] = {
'output': output,
'rc': rc,
@@ -198,7 +198,7 @@ def process_candidates(candidates, context, config_file, package_spec):
write_new_recipes_py(context, spec, repo_cfg_block)
rc, output = run_simulation_test(
- context.repo_root, package_spec, ['--train'])
+ context.repo_root, package_spec, ['train'])
roll_details[i]['recipes_simulation_test_train'] = {
'output': output,
'rc': rc,
@@ -268,7 +268,7 @@ def main(args, repo_root, config_file):
# Restore initial state. Since we could be running simulation tests
# on other revisions, re-run them now as well.
config_file.write(package_spec.dump())
- run_simulation_test(context.repo_root, package_spec, ['--train'],
+ run_simulation_test(context.repo_root, package_spec, ['train'],
allow_fetch=True)
if args.output_json:
« no previous file with comments | « no previous file | recipe_engine/test.py » ('j') | recipe_engine/test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698