Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2790493002: Implement permissions embargo for prompts which are repeatedly ignored. (Closed)
Patch Set: Not for plugins Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | chrome/common/chrome_features.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 7296d9af1594f80dcf2443a02f35dda5a730ddcf..e3333f042747d89cb4d9c25c78e37ba0eddd1f8d 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -302,11 +302,6 @@ void PermissionUmaUtil::PermissionIgnored(
RecordPermissionPromptPriorCount(
permission, kPermissionsPromptIgnoredPriorIgnoreCountPrefix,
autoblocker->GetIgnoreCount(requesting_origin, permission));
-
- // RecordPermission* methods need to be called before RecordIgnore in the
- // blocker because they record the number of prior ignore and dismiss values,
- // and we don't want to include the current ignore.
- autoblocker->RecordIgnore(requesting_origin, permission);
}
void PermissionUmaUtil::PermissionRevoked(ContentSettingsType permission,
@@ -343,6 +338,10 @@ void PermissionUmaUtil::RecordEmbargoPromptSuppressionFromSource(
PermissionUmaUtil::RecordEmbargoPromptSuppression(
PermissionEmbargoStatus::REPEATED_DISMISSALS);
break;
+ case PermissionStatusSource::MULTIPLE_IGNORES:
+ PermissionUmaUtil::RecordEmbargoPromptSuppression(
+ PermissionEmbargoStatus::REPEATED_IGNORES);
+ break;
case PermissionStatusSource::SAFE_BROWSING_BLACKLIST:
PermissionUmaUtil::RecordEmbargoPromptSuppression(
PermissionEmbargoStatus::PERMISSIONS_BLACKLISTING);
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | chrome/common/chrome_features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698