Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: chrome/browser/permissions/permission_request_impl.cc

Issue 2790493002: Implement permissions embargo for prompts which are repeatedly ignored. (Closed)
Patch Set: Not for plugins Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_impl.cc
diff --git a/chrome/browser/permissions/permission_request_impl.cc b/chrome/browser/permissions/permission_request_impl.cc
index 1a5bfad3576fac1b3bbdbe036fbe2ed9f8978b98..3c208d1f2eaab0c71d8f88bc520bab15f3398174 100644
--- a/chrome/browser/permissions/permission_request_impl.cc
+++ b/chrome/browser/permissions/permission_request_impl.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/permissions/permission_request_impl.h"
#include "build/build_config.h"
+#include "chrome/browser/permissions/permission_decision_auto_blocker.h"
#include "chrome/browser/permissions/permission_uma_util.h"
#include "chrome/browser/permissions/permission_util.h"
#include "chrome/grit/generated_resources.h"
@@ -40,8 +41,14 @@ PermissionRequestImpl::~PermissionRequestImpl() {
if (!action_taken_) {
PermissionUmaUtil::PermissionIgnored(
content_settings_type_, GetGestureType(), request_origin_, profile_);
- PermissionUmaUtil::RecordEmbargoStatus(
- PermissionEmbargoStatus::NOT_EMBARGOED);
+
+ PermissionEmbargoStatus embargo_status =
+ PermissionEmbargoStatus::NOT_EMBARGOED;
+ if (PermissionDecisionAutoBlocker::GetForProfile(profile_)
+ ->RecordIgnoreAndEmbargo(request_origin_, content_settings_type_)) {
+ embargo_status = PermissionEmbargoStatus::REPEATED_IGNORES;
+ }
+ PermissionUmaUtil::RecordEmbargoStatus(embargo_status);
}
}
« no previous file with comments | « chrome/browser/permissions/permission_infobar_delegate.cc ('k') | chrome/browser/permissions/permission_result.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698