Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Unified Diff: chrome/browser/permissions/permission_decision_auto_blocker.h

Issue 2790473004: Permissions: Clear embargo if user changes an embargoed permission's setting. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_decision_auto_blocker.h
diff --git a/chrome/browser/permissions/permission_decision_auto_blocker.h b/chrome/browser/permissions/permission_decision_auto_blocker.h
index c334628dd5188bf22609c2088c7009c9a7dc5d06..6b716d7f1048e21ef438ba102ed9dd1abdc37057 100644
--- a/chrome/browser/permissions/permission_decision_auto_blocker.h
+++ b/chrome/browser/permissions/permission_decision_auto_blocker.h
@@ -92,6 +92,13 @@ class PermissionDecisionAutoBlocker : public KeyedService {
// Records that an ignore of a prompt for |permission| was made.
int RecordIgnore(const GURL& url, ContentSettingsType permission);
+ // Removes the embargo status for the given URL. For permissions embargoed
+ // under repeated dismissals, this means a prompt will be shown to the user on
+ // next permission request. On blacklisted permissions, the next permission
+ // request will re-embargo the permission only if it is still blacklisted.
+ // This method assumes |permission| is known to be under embargo.
+ void RemoveEmbargoByURL(const GURL& url, ContentSettingsType permission);
dominickn 2017/04/03 01:35:30 Nit: call this RemoveEmbargoByUrl. "Removes the e
Patti Lor 2017/04/05 08:34:27 Done.
+
// Removes any recorded counts for urls which match |filter|.
void RemoveCountsByUrl(base::Callback<bool(const GURL& url)> filter);

Powered by Google App Engine
This is Rietveld 408576698