Permissions: Clear embargo if user changes an embargoed permission's setting.

chrome/browser/ui/page_info/page_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/page_info/page_info.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <string>
@@ skipping 14 matching lines @@
 #include "chrome/browser/browsing_data/browsing_data_cookie_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_database_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_file_system_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_indexed_db_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_local_storage_helper.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/content_settings/local_shared_objects_container.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/permissions/chooser_context_base.h"
+#include "chrome/browser/permissions/permission_decision_auto_blocker.h"
 #include "chrome/browser/permissions/permission_manager.h"
 #include "chrome/browser/permissions/permission_result.h"
 #include "chrome/browser/permissions/permission_uma_util.h"
 #include "chrome/browser/permissions/permission_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ssl/chrome_ssl_host_state_delegate.h"
 #include "chrome/browser/ssl/chrome_ssl_host_state_delegate_factory.h"
 #include "chrome/browser/ui/page_info/page_info_ui.h"
 #include "chrome/browser/usb/usb_chooser_context.h"
 #include "chrome/browser/usb/usb_chooser_context_factory.h"
@@ skipping 251 matching lines @@
         "WebsiteSettings.OriginInfo.PermissionChanged.Blocked", histogram_value,
         num_values);
   }
 
   // This is technically redundant given the histogram above, but putting the
   // total count of permission changes in another histogram makes it easier to
   // compare it against other kinds of actions in PageInfo[PopupView].
   RecordPageInfoAction(PAGE_INFO_CHANGED_PERMISSION);
 
   PermissionUtil::ScopedRevocationReporter scoped_revocation_reporter(
       this->profile_, this->site_url_, this->site_url_, type,

[dominickn, 2017/04/03 01:35:31]

Nit: the this-> usage here and below is weird (only place in this file). It's
not very C++. Can we remove this-> here and below?

[Patti Lor, 2017/04/05 08:34:27]

Sorry, I thought for some reason there was a reason for that and was trying to
be consistent - it doesn't actually look like there is though. Fixed, thanks!

       PermissionSourceUI::OIB);
 
+  // If the setting was changed away from an embargo status (which will always
+  // be BLOCK), clear the embargo.
+  if (setting != CONTENT_SETTING_BLOCK && PermissionUtil::IsPermission(type)) {
+    PermissionResult permission_result =
+        PermissionManager::Get(profile_)->GetPermissionStatus(
+            type, this->site_url_, this->site_url_);
+    switch (permission_result.source) {
+      case PermissionStatusSource::MULTIPLE_DISMISSALS:
+      case PermissionStatusSource::SAFE_BROWSING_BLACKLIST:
+        PermissionDecisionAutoBlocker::GetForProfile(profile_)
+            ->RemoveEmbargoByURL(this->site_url_, type);
+        break;
+      default:
+        break;
+    }
+  }
   content_settings_->SetNarrowestContentSetting(site_url_, site_url_, type,
                                                 setting);
 
   show_info_bar_ = true;
 
   // Refresh the UI to reflect the new setting.
   PresentSitePermissions();
 }
 
 void PageInfo::OnSiteChosenObjectDeleted(const ChooserUIInfo& ui_info,
@@ skipping 422 matching lines @@
     info.site_identity = UTF16ToUTF8(GetSimpleSiteName(site_url_));
 
   info.connection_status = site_connection_status_;
   info.connection_status_description = UTF16ToUTF8(site_connection_details_);
   info.identity_status = site_identity_status_;
   info.identity_status_description = UTF16ToUTF8(site_identity_details_);
   info.certificate = certificate_;
   info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_;
   ui_->SetIdentityInfo(info);
 }