third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.php - Issue 2790433003: Support redirect responses for NavigationPreload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.php

Issue 2790433003: Support redirect responses for NavigationPreload (Closed)

Patch Set: incorporated falken's comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-scope.php ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.php

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.php b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.php

index 0628400009093c99750af6c05204807dd838d668..ccf6c07008ea9c6dd0d15e143274e18e2ed1650d 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.php

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.php

@@ -17,12 +17,6 @@ self.addEventListener('fetch', event => {

.catch(_ => { return new Response('dummy'); }));

return;

}

- if (event.request.url.indexOf('RedirectError') != -1) {

- event.respondWith(

- event.preloadResponse

- .catch(_ => { return new Response('dummy'); }));

- return;

- }

if (event.preloadResponse) {

event.respondWith(event.preloadResponse);

}