Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6608)

Unified Diff: chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Issue 2790353002: [MD Bookmarks] Auto expand folders on drag hover. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
diff --git a/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js b/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
index 225cb79557ba5774506f50c80fed6b9238715fb2..caa18b1eaf83f002a1083b01894f241505f787cf 100644
--- a/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
+++ b/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
@@ -386,4 +386,52 @@ suite('drag and drop', function() {
dispatchDragEvent('dragend', dragTarget);
assertDragStyle(dragTarget, DRAG_STYLE.NONE);
});
+
+ test('auto expander', function() {
+ var autoExpander = dndManager.autoExpander_;
+ store.data.closedFolders = new Set(['11']);
+ store.notifyObservers();
+ Polymer.dom.flush();
+
+ var dragElement = getFolderNode('14');
+ var dragTarget = getFolderNode('15');
+ autoExpander.testTimestamp_ = 500;
+
+ dispatchDragEvent('dragstart', dragElement);
+ dndManager.dragInfo_.handleChromeDragEnter(createDragData(draggedIds));
+
+
tsergeant 2017/04/05 07:49:36 Nit: extra \n
calamity 2017/04/10 03:38:12 Done.
+ // Dragging onto folders without children doesn't update the auto expander.
+ dispatchDragEvent('dragover', dragTarget);
+ assertEquals(0, autoExpander.lastTimestamp_);
+
+ // Dragging onto open folders doesn't update the auto expander.
+ dragTarget = getFolderNode('1');
+ dispatchDragEvent('dragover', dragTarget);
+ assertEquals(0, autoExpander.lastTimestamp_);
+
+ // Dragging onto a closed folder with children updates the auto expander.
+ dragTarget = getFolderNode('11');
+ dispatchDragEvent('dragover', dragTarget);
+ assertEquals(500, autoExpander.lastTimestamp_);
+ assertEquals(dragTarget, autoExpander.lastElement_);
+
+ // Dragging onto another item resets the auto expander.
+ autoExpander.testTimestamp_ = 700;
+ dragTarget = getFolderNode('1');
+ dispatchDragEvent('dragover', dragTarget);
+ assertEquals(0, autoExpander.lastTimestamp_);
tsergeant 2017/04/05 07:49:36 Add a case for when overelement is null
calamity 2017/04/10 03:38:12 Done.
+
+ // Auto expands after expand delay.
+ dragTarget = getFolderNode('11');
+ dispatchDragEvent('dragover', dragTarget);
+ assertEquals(700, autoExpander.lastTimestamp_);
+
+ autoExpander.testTimestamp_ += autoExpander.EXPAND_FOLDER_DELAY;
+ dispatchDragEvent('dragover', dragTarget);
+ assertDeepEquals(
+ bookmarks.actions.changeFolderOpen('11', true), store.lastAction);
+ assertEquals(0, autoExpander.lastTimestamp_);
+ assertEquals(null, autoExpander.lastElement_);
+ });
});

Powered by Google App Engine
This is Rietveld 408576698