Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Issue 2790353002: [MD Bookmarks] Auto expand folders on drag hover. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 suite('drag and drop', function() { 5 suite('drag and drop', function() {
6 var app; 6 var app;
7 var list; 7 var list;
8 var sidebar; 8 var sidebar;
9 var store; 9 var store;
10 var dndManager; 10 var dndManager;
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 'dragover', dragTarget, MockInteractions.topLeftOfNode(dragTarget)); 379 'dragover', dragTarget, MockInteractions.topLeftOfNode(dragTarget));
380 assertDragStyle(dragTarget, DRAG_STYLE.ABOVE); 380 assertDragStyle(dragTarget, DRAG_STYLE.ABOVE);
381 381
382 dispatchDragEvent('drop', dragTarget); 382 dispatchDragEvent('drop', dragTarget);
383 assertEquals('1', dropParentId); 383 assertEquals('1', dropParentId);
384 assertEquals(1, dropIndex); 384 assertEquals(1, dropIndex);
385 385
386 dispatchDragEvent('dragend', dragTarget); 386 dispatchDragEvent('dragend', dragTarget);
387 assertDragStyle(dragTarget, DRAG_STYLE.NONE); 387 assertDragStyle(dragTarget, DRAG_STYLE.NONE);
388 }); 388 });
389
390 test('auto expander', function() {
391 var autoExpander = dndManager.autoExpander_;
392 store.data.closedFolders = new Set(['11']);
393 store.notifyObservers();
394 Polymer.dom.flush();
395
396 var dragElement = getFolderNode('14');
397 var dragTarget = getFolderNode('15');
398 autoExpander.testTimestamp_ = 500;
399
400 dispatchDragEvent('dragstart', dragElement);
401 dndManager.dragInfo_.handleChromeDragEnter(createDragData(draggedIds));
402
403
tsergeant 2017/04/05 07:49:36 Nit: extra \n
calamity 2017/04/10 03:38:12 Done.
404 // Dragging onto folders without children doesn't update the auto expander.
405 dispatchDragEvent('dragover', dragTarget);
406 assertEquals(0, autoExpander.lastTimestamp_);
407
408 // Dragging onto open folders doesn't update the auto expander.
409 dragTarget = getFolderNode('1');
410 dispatchDragEvent('dragover', dragTarget);
411 assertEquals(0, autoExpander.lastTimestamp_);
412
413 // Dragging onto a closed folder with children updates the auto expander.
414 dragTarget = getFolderNode('11');
415 dispatchDragEvent('dragover', dragTarget);
416 assertEquals(500, autoExpander.lastTimestamp_);
417 assertEquals(dragTarget, autoExpander.lastElement_);
418
419 // Dragging onto another item resets the auto expander.
420 autoExpander.testTimestamp_ = 700;
421 dragTarget = getFolderNode('1');
422 dispatchDragEvent('dragover', dragTarget);
423 assertEquals(0, autoExpander.lastTimestamp_);
tsergeant 2017/04/05 07:49:36 Add a case for when overelement is null
calamity 2017/04/10 03:38:12 Done.
424
425 // Auto expands after expand delay.
426 dragTarget = getFolderNode('11');
427 dispatchDragEvent('dragover', dragTarget);
428 assertEquals(700, autoExpander.lastTimestamp_);
429
430 autoExpander.testTimestamp_ += autoExpander.EXPAND_FOLDER_DELAY;
431 dispatchDragEvent('dragover', dragTarget);
432 assertDeepEquals(
433 bookmarks.actions.changeFolderOpen('11', true), store.lastAction);
434 assertEquals(0, autoExpander.lastTimestamp_);
435 assertEquals(null, autoExpander.lastElement_);
436 });
389 }); 437 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698