Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Issue 2790353002: [MD Bookmarks] Auto expand folders on drag hover. (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/md_bookmarks/dnd_manager.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 suite('drag and drop', function() { 5 suite('drag and drop', function() {
6 var app; 6 var app;
7 var list; 7 var list;
8 var sidebar; 8 var sidebar;
9 var store; 9 var store;
10 var dndManager; 10 var dndManager;
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 'dragover', dragTarget, MockInteractions.topLeftOfNode(dragTarget)); 379 'dragover', dragTarget, MockInteractions.topLeftOfNode(dragTarget));
380 assertDragStyle(dragTarget, DRAG_STYLE.ABOVE); 380 assertDragStyle(dragTarget, DRAG_STYLE.ABOVE);
381 381
382 dispatchDragEvent('drop', dragTarget); 382 dispatchDragEvent('drop', dragTarget);
383 assertEquals('1', dropParentId); 383 assertEquals('1', dropParentId);
384 assertEquals(1, dropIndex); 384 assertEquals(1, dropIndex);
385 385
386 dispatchDragEvent('dragend', dragTarget); 386 dispatchDragEvent('dragend', dragTarget);
387 assertDragStyle(dragTarget, DRAG_STYLE.NONE); 387 assertDragStyle(dragTarget, DRAG_STYLE.NONE);
388 }); 388 });
389
390 test('auto expander', function() {
391 var autoExpander = dndManager.autoExpander_;
392 store.data.closedFolders = new Set(['11']);
393 store.notifyObservers();
394 Polymer.dom.flush();
395
396 var dragElement = getFolderNode('14');
397 var dragTarget = getFolderNode('15');
398 autoExpander.testTimestamp_ = 500;
399
400 dispatchDragEvent('dragstart', dragElement);
401 dndManager.dragInfo_.handleChromeDragEnter(createDragData(draggedIds));
402
403 // Dragging onto folders without children doesn't update the auto expander.
404 dispatchDragEvent('dragover', dragTarget);
405 assertEquals(null, autoExpander.lastElement_);
406
407 // Dragging onto open folders doesn't update the auto expander.
408 dragTarget = getFolderNode('1');
409 dispatchDragEvent('dragover', dragTarget);
410 assertEquals(null, autoExpander.lastElement_);
411
412 // Dragging onto a closed folder with children updates the auto expander.
413 dragTarget = getFolderNode('11');
414 dispatchDragEvent('dragover', dragTarget);
415 assertEquals(500, autoExpander.lastTimestamp_);
416 assertEquals(dragTarget, autoExpander.lastElement_);
417
418 // Dragging onto another item resets the auto expander.
419 autoExpander.testTimestamp_ = 700;
420 dragTarget = getFolderNode('1');
421 dispatchDragEvent('dragover', dragTarget);
422 assertEquals(null, autoExpander.lastElement_);
423
424 // Dragging onto the list resets the auto expander.
425 dragTarget = getFolderNode('11');
426 dispatchDragEvent('dragover', dragTarget);
427 assertEquals(700, autoExpander.lastTimestamp_);
428 assertEquals(dragTarget, autoExpander.lastElement_);
429
430 dragTarget = list;
431 dispatchDragEvent('dragover', dragTarget);
432 assertEquals(null, autoExpander.lastElement_);
433
434 // Auto expands after expand delay.
435 dragTarget = getFolderNode('11');
436 dispatchDragEvent('dragover', dragTarget);
437 assertEquals(700, autoExpander.lastTimestamp_);
438
439 autoExpander.testTimestamp_ += autoExpander.EXPAND_FOLDER_DELAY;
440 dispatchDragEvent('dragover', dragTarget);
441 assertDeepEquals(
442 bookmarks.actions.changeFolderOpen('11', true), store.lastAction);
443 assertEquals(0, autoExpander.lastTimestamp_);
444 assertEquals(null, autoExpander.lastElement_);
445 });
389 }); 446 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/md_bookmarks/dnd_manager.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698