Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: WATCHLISTS

Issue 2790313002: Add chooser watchlist and add ortuno to it (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Watchlist Rules 5 # Watchlist Rules
6 # Refer: http://dev.chromium.org/developers/contributing-code/watchlists 6 # Refer: http://dev.chromium.org/developers/contributing-code/watchlists
7 7
8 # IMPORTANT: The regular expression filepath is tested against each path using 8 # IMPORTANT: The regular expression filepath is tested against each path using
9 # re.search, so it is not usually necessary to add .*. 9 # re.search, so it is not usually necessary to add .*.
10 10
(...skipping 19 matching lines...) Expand all
30 '|chrome/browser/extensions/api/activity_log_private/' 30 '|chrome/browser/extensions/api/activity_log_private/'
31 }, 31 },
32 'add_to_homescreen': { 32 'add_to_homescreen': {
33 'filepath': 'chrome/android/java/src/org/chromium/chrome/browser/webapps/| '\ 33 'filepath': 'chrome/android/java/src/org/chromium/chrome/browser/webapps/| '\
34 'chrome/android/javatests/src/org/chromium/chrome/browser/weba pps/|'\ 34 'chrome/android/javatests/src/org/chromium/chrome/browser/weba pps/|'\
35 'chrome/android/junit/src/org/chromium/chrome/browser/webapps/ |'\ 35 'chrome/android/junit/src/org/chromium/chrome/browser/webapps/ |'\
36 'chrome/android/javatests/src/org/chromium/chrome/browser/bann ers/|'\ 36 'chrome/android/javatests/src/org/chromium/chrome/browser/bann ers/|'\
37 'chrome/browser/android/shortcut_.*|'\ 37 'chrome/browser/android/shortcut_.*|'\
38 'chrome/browser/android/webapps/', 38 'chrome/browser/android/webapps/',
39 }, 39 },
40 'android_chooser_dialogs': {
juncai 2017/04/04 00:26:46 'android_chooser_dialogs' seems too general, what
ortuno 2017/04/04 00:35:37 android_device_chooser_dialogs would limit us to U
juncai 2017/04/04 00:46:16 hmm... still feel that the 'android_chooser_dialog
ortuno 2017/04/05 00:11:17 I see. Done.
41 'filepath': 'chrome/android/java/src/org/chromium/chrome/browser/.*Chooser Dialog.java|'\
42 'chrome/android/javatests/src/org/chromium/chrome/browser/.*Ch ooserDialogTest.java|'\
43 },
40 'android_crash_reporting': { 44 'android_crash_reporting': {
41 'filepath': 'chrome/android/java/src/org/chromium/chrome/browser/crash/' 45 'filepath': 'chrome/android/java/src/org/chromium/chrome/browser/crash/'
42 }, 46 },
43 'android_crazy_linker': { 47 'android_crazy_linker': {
44 'filepath': 'third_party/android_crazy_linker/' 48 'filepath': 'third_party/android_crazy_linker/'
45 }, 49 },
46 'android_infobars': { 50 'android_infobars': {
47 'filepath': 'chrome/android/java/src/org/chromium/chrome/browser/infobar/' 51 'filepath': 'chrome/android/java/src/org/chromium/chrome/browser/infobar/'
48 }, 52 },
49 'android_infra': { 53 'android_infra': {
(...skipping 1506 matching lines...) Expand 10 before | Expand all | Expand 10 after
1556 'dougt+watch@chromium.org', 1560 'dougt+watch@chromium.org',
1557 'dtseng+watch@chromium.org', 1561 'dtseng+watch@chromium.org',
1558 'je_julie.kim@chromium.org', 1562 'je_julie.kim@chromium.org',
1559 'nektar+watch@chromium.org', 1563 'nektar+watch@chromium.org',
1560 'yuzo+watch@chromium.org'], 1564 'yuzo+watch@chromium.org'],
1561 'add_to_homescreen': ['agrieve+watch@chromium.org', 1565 'add_to_homescreen': ['agrieve+watch@chromium.org',
1562 'dominickn+watch@chromium.org', 1566 'dominickn+watch@chromium.org',
1563 'pkotwicz+watch@chromium.org', 1567 'pkotwicz+watch@chromium.org',
1564 'zpeng+watch@chromium.org'], 1568 'zpeng+watch@chromium.org'],
1565 'android_crash_reporting': ['asvitkine+watch@chromium.org'], 1569 'android_crash_reporting': ['asvitkine+watch@chromium.org'],
1570 'android_chooser_dialogs': ['ortuno+watch@chromium.org'],
1566 'android_crazy_linker': ['johnmaguire+watch@google.com'], 1571 'android_crazy_linker': ['johnmaguire+watch@google.com'],
1567 'android_infobars': ['dfalcantara+watch@chromium.org'], 1572 'android_infobars': ['dfalcantara+watch@chromium.org'],
1568 'android_infra': ['agrieve+watch@chromium.org', 1573 'android_infra': ['agrieve+watch@chromium.org',
1569 'jbudorick+watch@chromium.org', 1574 'jbudorick+watch@chromium.org',
1570 'mikecase+watch@chromium.org'], 1575 'mikecase+watch@chromium.org'],
1571 'android_java': ['agrieve+watch@chromium.org'], 1576 'android_java': ['agrieve+watch@chromium.org'],
1572 'android_loading': ['gabadie+watch@chromium.org', 1577 'android_loading': ['gabadie+watch@chromium.org',
1573 'lizeb+watch-android-loading@chromium.org'], 1578 'lizeb+watch-android-loading@chromium.org'],
1574 'android_media': ['avayvod+watch@chromium.org', 1579 'android_media': ['avayvod+watch@chromium.org',
1575 'mlamouri+watch-media@chromium.org'], 1580 'mlamouri+watch-media@chromium.org'],
(...skipping 649 matching lines...) Expand 10 before | Expand all | Expand 10 after
2225 'msramek+watch@chromium.org', 2230 'msramek+watch@chromium.org',
2226 'raymes+watch@chromium.org'], 2231 'raymes+watch@chromium.org'],
2227 'windows_sandboxing': ['pennymac+watch@chromium.org', 2232 'windows_sandboxing': ['pennymac+watch@chromium.org',
2228 'wfh+watch@chromium.org'], 2233 'wfh+watch@chromium.org'],
2229 'x11': ['derat+watch@chromium.org', 2234 'x11': ['derat+watch@chromium.org',
2230 'sadrul@chromium.org', 2235 'sadrul@chromium.org',
2231 'yusukes+watch@chromium.org'], 2236 'yusukes+watch@chromium.org'],
2232 'zoom': ['wjmaclean@chromium.org'], 2237 'zoom': ['wjmaclean@chromium.org'],
2233 }, 2238 },
2234 } 2239 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698