Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h

Issue 2790283003: Reset constraint space's BFC offset if block creates a new FC (Closed)
Patch Set: git rebase-update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h b/third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h
index 7b5333a38bbc4e353b5aa496469f3ac8f6d8617c..985b8b5baf9475962006bc2dc98d5d9a33f9957e 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_floats_utils.h
@@ -8,16 +8,20 @@
#include "core/layout/ng/geometry/ng_logical_offset.h"
#include "core/layout/ng/ng_constraint_space.h"
#include "core/layout/ng/ng_floating_object.h"
+#include "core/layout/ng/ng_fragment_builder.h"
namespace blink {
-// Calculates the relative position from {@code from_offset} of the
-// floating object that is requested to be positioned from {@code origin_point}.
-CORE_EXPORT NGLogicalOffset PositionFloat(const NGLogicalOffset& origin_point,
- const NGLogicalOffset& from_offset,
- NGFloatingObject*,
+// Positions {@code floating_object} into {@code new_parent_space}.
+// @returns Logical offset of the positioned float.
+CORE_EXPORT NGLogicalOffset PositionFloat(NGFloatingObject*,
NGConstraintSpace* new_parent_space);
+// Positions pending floats stored on the fragment builder starting from
+// {@code origin_block_offset}.
+void PositionPendingFloats(const LayoutUnit& origin_block_offset,
+ NGConstraintSpace* space,
+ NGFragmentBuilder* builder);
} // namespace blink
#endif // NGFloatsUtils_h

Powered by Google App Engine
This is Rietveld 408576698