Do not rewrite the VM isolate's symbol table during AOT snapshots.

Do not rewrite the VM isolate's symbol table during AOT snapshots.

This has the effect of making every program generate the same VM isolate, allowing an embedder to load different programs into different isolates.

Verify the number of base objects in clustered snapshots.

Remove dead code leftover from core snapshots switching from saving scripts to saving token streams in the VM isolate.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/22eee804cddfe768a575705caa613cc0d540cbc3

[rmacnak, 2017-04-03 20:57:29]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-04-06 19:19:40]

lgtm

https://codereview.chromium.org/2790243003/diff/20001/runtime/vm/clustered_sn...
File runtime/vm/clustered_snapshot.cc (right):

https://codereview.chromium.org/2790243003/diff/20001/runtime/vm/clustered_sn...
runtime/vm/clustered_snapshot.cc:5368: // VM that has loaded this snapshots,
much like app-jit snapshots.
this snapshot?

[rmacnak, 2017-04-06 20:09:48]

https://codereview.chromium.org/2790243003/diff/20001/runtime/vm/clustered_sn...
File runtime/vm/clustered_snapshot.cc (right):

https://codereview.chromium.org/2790243003/diff/20001/runtime/vm/clustered_sn...
runtime/vm/clustered_snapshot.cc:5368: // VM that has loaded this snapshots,
much like app-jit snapshots.
On 2017/04/06 19:19:40, siva wrote:
> this snapshot?

Clarified comment that it is AOT snapshots which need cleanup.

[rmacnak, 2017-04-06 20:22:30]

Description was changed from

==========
Do not rewrite the VM isolate's symbol table during AOT snapshots.

This has the effect of making every program generate the same VM isolate,
allowing an embedder to load different programs into different isolates.

Verify the number of base objects in clustered snapshots.

Remove dead code leftover from core snapshots switching from saving scripts to
saving token streams in the VM isolate.
==========

to

==========
Do not rewrite the VM isolate's symbol table during AOT snapshots.

This has the effect of making every program generate the same VM isolate,
allowing an embedder to load different programs into different isolates.

Verify the number of base objects in clustered snapshots.

Remove dead code leftover from core snapshots switching from saving scripts to
saving token streams in the VM isolate.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/22eee804cddfe768a575705caa613cc0d540cbc3
==========

[rmacnak, 2017-04-06 20:22:31]

Committed patchset #3 (id:40001) manually as
22eee804cddfe768a575705caa613cc0d540cbc3 (presubmit successful).