Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

Issue 2790213004: Don't try to update incessently when Shell APK version is out of date. (Closed)
Patch Set: Move the shell apk version check back to WebApkUpdateManager. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
index 98a656712c6aa54ac198077dbed51a87d1c0da17..b27cca610c0f763ef5635364b94efe625e78c0a6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
@@ -285,7 +285,11 @@ public class WebApkUpdateManager implements WebApkUpdateDataFetcher.Observer {
return true;
}
- if (isShellApkVersionOutOfDate(info)) return true;
+ if (isShellApkVersionOutOfDate(info)
+ && WebApkVersion.CURRENT_SHELL_APK_VERSION
+ > mStorage.getLastRequestedShellApkVersion()) {
+ return true;
+ }
return mStorage.shouldCheckForUpdate();
}
@@ -363,6 +367,7 @@ public class WebApkUpdateManager implements WebApkUpdateDataFetcher.Observer {
if (storage == null) return;
recordUpdate(storage, result, relaxUpdates);
+ storage.updateLastRequestedShellApkVersion(WebApkVersion.CURRENT_SHELL_APK_VERSION);
}
private static native void nativeUpdateAsync(String id, String startUrl, String scope,
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698