Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

Issue 2790183002: Add UMA for the content suggestions settings (Closed)
Patch Set: Rewrite metrics and add histograms changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java
index ed299336897ca1d862100d376a09133bc6367664..68a5f482df5047a3f77657d8563746e28cff396b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java
@@ -31,7 +31,6 @@
import org.chromium.chrome.browser.notifications.NotificationUmaTracker;
import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsNotificationAction;
import org.chromium.chrome.browser.preferences.ContentSuggestionsPreferences;
-import org.chromium.chrome.browser.preferences.PreferencesLauncher;
import java.util.Collection;
import java.util.Collections;
@@ -173,8 +172,8 @@ private static boolean showNotification(int category, String idWithinCategory, S
.setSmallIcon(R.drawable.ic_chrome);
if (ChromeFeatureList.isEnabled(ChromeFeatureList.CONTENT_SUGGESTIONS_SETTINGS)) {
PendingIntent settingsIntent = PendingIntent.getActivity(context, 0,
- PreferencesLauncher.createIntentForSettingsPage(
- context, ContentSuggestionsPreferences.class.getName()),
+ ContentSuggestionsPreferences.getIntent(
+ context, ContentSuggestionsPreferences.LAUNCH_SOURCE_NOTIFICATION),
0);
builder.addAction(R.drawable.settings_cog, context.getString(R.string.preferences),
settingsIntent);

Powered by Google App Engine
This is Rietveld 408576698