components/ntp_snippets/content_suggestions_metrics.h - Issue 2790183002: Add UMA for the content suggestions settings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/content_suggestions_metrics.h

Issue 2790183002: Add UMA for the content suggestions settings (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ntp_snippets/ntp_snippets_metrics.h ('k') | components/ntp_snippets/content_suggestions_metrics.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_METRICS_H_	5 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_METRICS_H_

6 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_METRICS_H_	6 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_METRICS_H_

7	7

8 #include <utility>	8 #include <utility>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51	51

52 void OnCategoryMovedUp(int new_index);	52 void OnCategoryMovedUp(int new_index);

53	53

54 // Should only be called once per NTP for each "more" button.	54 // Should only be called once per NTP for each "more" button.

55 void OnMoreButtonShown(Category category, int position);	55 void OnMoreButtonShown(Category category, int position);

56	56

57 void OnMoreButtonClicked(Category category, int position);	57 void OnMoreButtonClicked(Category category, int position);

58	58

59 void OnCategoryDismissed(Category category);	59 void OnCategoryDismissed(Category category);

60	60

	61 void RecordRemoteSuggestionsServiceState(bool enabled);
	Marc Treib 2017/04/07 09:00:34 nit: Should this be RemoteSuggestionsProvider? It' nit: Should this be RemoteSuggestionsProvider? It's not actually a service. dgn 2017/04/07 10:24:55 Done. Show quoted text On 2017/04/07 09:00:34, Marc Treib wrote: > nit: Should this be RemoteSuggestionsProvider? It's not actually a service. Done.
	62

61 } // namespace metrics	63 } // namespace metrics

62 } // namespace ntp_snippets	64 } // namespace ntp_snippets

63	65

64 #endif // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_H_	66 #endif // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_H_

OLD	NEW