Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2790173003: Bug fixes and added support for creating source edits (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -51 lines) Patch
M pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_dart.dart View 5 chunks +42 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_core.dart View 3 chunks +28 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_dart.dart View 11 chunks +92 lines, -33 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 8 months ago (2017-04-03 16:53:53 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2790173003/diff/1/pkg/analysis_server/lib/src/utilities/change_builder_dart.dart File pkg/analysis_server/lib/src/utilities/change_builder_dart.dart (right): https://codereview.chromium.org/2790173003/diff/1/pkg/analysis_server/lib/src/utilities/change_builder_dart.dart#newcode85 pkg/analysis_server/lib/src/utilities/change_builder_dart.dart:85: // } Should this be removed?
3 years, 8 months ago (2017-04-03 17:06:06 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2790173003/diff/1/pkg/analysis_server/lib/src/utilities/change_builder_dart.dart File pkg/analysis_server/lib/src/utilities/change_builder_dart.dart (right): https://codereview.chromium.org/2790173003/diff/1/pkg/analysis_server/lib/src/utilities/change_builder_dart.dart#newcode85 pkg/analysis_server/lib/src/utilities/change_builder_dart.dart:85: // } Probably. I'll catch it in the next ...
3 years, 8 months ago (2017-04-03 17:14:41 UTC) #4
Brian Wilkerson
3 years, 8 months ago (2017-04-03 17:56:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0ea61b64abcdb1be3c53080ab2218eceff782428 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698