Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: pkg/kernel/lib/binary/ast_from_binary.dart

Issue 2790093002: Hacky streaming of VariableGet (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/lib/binary/ast_from_binary.dart
diff --git a/pkg/kernel/lib/binary/ast_from_binary.dart b/pkg/kernel/lib/binary/ast_from_binary.dart
index 64563eb27bd79e1f7c6b6f89ac18e8fa7c6f0ca0..3491cbb155661965f99b87786936c7053984788e 100644
--- a/pkg/kernel/lib/binary/ast_from_binary.dart
+++ b/pkg/kernel/lib/binary/ast_from_binary.dart
@@ -637,11 +637,13 @@ class BinaryBuilder {
return new InvalidExpression();
case Tag.VariableGet:
int offset = readOffset();
+ readUInt(); // offset in binary. Unused here.
Kevin Millikin (Google) 2017/04/05 08:59:57 // Offset of the declaration. I think it's obviou
return new VariableGet(readVariableReference(), readDartTypeOption())
..fileOffset = offset;
case Tag.SpecializedVariableGet:
int index = tagByte & Tag.SpecializedPayloadMask;
int offset = readOffset();
+ readUInt(); // offset in binary. Unused here.
return new VariableGet(variableStack[index])..fileOffset = offset;
case Tag.VariableSet:
int offset = readOffset();

Powered by Google App Engine
This is Rietveld 408576698