Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: runtime/vm/kernel.h

Issue 2790073004: Restructure the Kernel string table. (Closed)
Patch Set: Incorporate review comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/binary/ast_to_binary.dart ('k') | runtime/vm/kernel_binary.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel.h
diff --git a/runtime/vm/kernel.h b/runtime/vm/kernel.h
index 81e5dcc1bc76c6a4d1499623034de9733f98ef66..f8568ee5b44eabc076deee6b90ba409ee9a848c7 100644
--- a/runtime/vm/kernel.h
+++ b/runtime/vm/kernel.h
@@ -257,9 +257,16 @@ class Tuple {
class String {
public:
+ // Read a string reference, which is an index into the string table.
static String* ReadFrom(Reader* reader);
+
+ // Read a string implementation, which is a size followed by a UTF-8
+ // encoded string.
static String* ReadFromImpl(Reader* reader);
+ // Read a string implementation given its size.
+ static String* ReadRaw(Reader* reader, intptr_t size);
+
String(const uint8_t* utf8, int length) {
buffer_ = new uint8_t[length];
size_ = length;
« no previous file with comments | « pkg/kernel/lib/binary/ast_to_binary.dart ('k') | runtime/vm/kernel_binary.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698