Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1622)

Side by Side Diff: chrome/test/sync/engine/test_directory_setter_upper.cc

Issue 279004: Made sync code build and pass unit tests on OS X. (Closed)
Patch Set: Fixed uninitialized var error. Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/sync/engine/test_directory_setter_upper.h" 5 #include "chrome/test/sync/engine/test_directory_setter_upper.h"
6 6
7 #include "base/string_util.h" 7 #include "base/string_util.h"
8 #include "chrome/browser/sync/syncable/directory_manager.h" 8 #include "chrome/browser/sync/syncable/directory_manager.h"
9 #include "chrome/browser/sync/syncable/syncable.h" 9 #include "chrome/browser/sync/syncable/syncable.h"
10 #include "chrome/browser/sync/util/character_set_converters.h" 10 #include "chrome/browser/sync/util/character_set_converters.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 void ManuallyOpenedTestDirectorySetterUpper::Open() { 78 void ManuallyOpenedTestDirectorySetterUpper::Open() {
79 ASSERT_TRUE(manager()->Open(name())); 79 ASSERT_TRUE(manager()->Open(name()));
80 was_opened_ = true; 80 was_opened_ = true;
81 } 81 }
82 82
83 void ManuallyOpenedTestDirectorySetterUpper::TearDown() { 83 void ManuallyOpenedTestDirectorySetterUpper::TearDown() {
84 if (was_opened_) { 84 if (was_opened_) {
85 TestDirectorySetterUpper::TearDown(); 85 TestDirectorySetterUpper::TearDown();
86 } 86 }
87 } 87 }
88
89 static PathString UTF8ToPathStringQuick(const std::string &str) {
90 PathString ret;
91 CHECK(browser_sync::UTF8ToPathString(str.data(), str.size(), &ret));
92 return ret;
93 }
94 88
95 TriggeredOpenTestDirectorySetterUpper::TriggeredOpenTestDirectorySetterUpper( 89 TriggeredOpenTestDirectorySetterUpper::TriggeredOpenTestDirectorySetterUpper(
96 const std::string& name) 90 const std::string& name)
97 : TestDirectorySetterUpper(UTF8ToPathStringQuick(name)) { 91 : TestDirectorySetterUpper(UTF8ToPathStringQuick(name)) {
98 } 92 }
99 93
100 void TriggeredOpenTestDirectorySetterUpper::SetUp() { 94 void TriggeredOpenTestDirectorySetterUpper::SetUp() {
101 Init(); 95 Init();
102 } 96 }
103 97
104 void TriggeredOpenTestDirectorySetterUpper::TearDown() { 98 void TriggeredOpenTestDirectorySetterUpper::TearDown() {
105 DirectoryManager::DirNames names; 99 DirectoryManager::DirNames names;
106 manager()->GetOpenDirectories(&names); 100 manager()->GetOpenDirectories(&names);
107 if (!names.empty()) { 101 if (!names.empty()) {
108 ASSERT_EQ(1U, names.size()); 102 ASSERT_EQ(1U, names.size());
109 ASSERT_EQ(name(), names[0]); 103 ASSERT_EQ(name(), names[0]);
110 TestDirectorySetterUpper::TearDown(); 104 TestDirectorySetterUpper::TearDown();
111 } 105 }
112 } 106 }
113 107
114 } // namespace browser_sync 108 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698