Issue 279001: Move autofill related WebView{Delegate} methods into the WebKit API....

Issue 279001: Move autofill related WebView{Delegate} methods into the WebKit API.... (Closed)

Created:
11 years, 2 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move autofill related WebView{Delegate} methods into the WebKit API. This CL also changes a bunch of autofill related wstring values to string16. R=jcampan BUG=24595 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29244

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+335 lines, -294 lines)			Patch
M	chrome/browser/autofill_manager.h	View	1 2 3 4	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/autofill_manager.cc	View	1 2 3 4	4 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View	1 2 3 4	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 2 3 4	2 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View	1 2 3 4	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service.h	View	1 2 3 4	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service.cc	View	1 2 3 4	4 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/webdata/web_database.h	View	1 2 3 4	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View	1 2 3 4	8 chunks	+16 lines, -17 lines	0 comments	Download
M	chrome/browser/webdata/web_database_unittest.cc	View	4 5	3 chunks	+43 lines, -29 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1 2 3 4	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.h	View	1 2 3 4	1 chunk	+8 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1 2 3 4	5 chunks	+11 lines, -10 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2 3 4	4 chunks	+25 lines, -26 lines	0 comments	Download
M	webkit/api/public/WebView.h	View	1 2 3 4	2 chunks	+15 lines, -0 lines	0 comments	Download
M	webkit/api/public/WebViewClient.h	View	1 2 3 4	1 chunk	+15 lines, -0 lines	0 comments	Download
M	webkit/glue/autofill_form.h	View	1 2 3 4	2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/autofill_form.cc	View	1 2 3 4	2 chunks	+7 lines, -7 lines	0 comments	Download
M	webkit/glue/editor_client_impl.cc	View	1 2 3 4 5	5 chunks	+10 lines, -9 lines	0 comments	Download
M	webkit/glue/password_autocomplete_listener.h	View	1 2 3 4	3 chunks	+9 lines, -9 lines	0 comments	Download
M	webkit/glue/password_autocomplete_listener.cc	View	1 2 3 4 5	9 chunks	+29 lines, -23 lines	0 comments	Download
M	webkit/glue/password_autocomplete_listener_unittest.cc	View	5 6	12 chunks	+33 lines, -30 lines	0 comments	Download
M	webkit/glue/webview.h	View	1 2 3 4	1 chunk	+0 lines, -9 lines	0 comments	Download
M	webkit/glue/webview_delegate.h	View	1 2 3 4	1 chunk	+0 lines, -15 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View	1 2 3 4	1 chunk	+5 lines, -5 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	1 2 3 4	12 chunks	+35 lines, -34 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 2 3 4	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages