Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2789933002: Add runtime tests for ignored checks (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/dev_compiler/test/browser/runtime_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/test/browser/language_tests.js
diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js
index 010334fa617e1eecb2721b169db852d8b92cc1fb..e271215cea01402907320de77e8a75f02c7e0b8c 100644
--- a/pkg/dev_compiler/test/browser/language_tests.js
+++ b/pkg/dev_compiler/test/browser/language_tests.js
@@ -860,7 +860,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
test('run all dart unittests', function(done) { // 'function' to allow `this.timeout`
// Use the whitelist for all unittests - there may be an error in the framework
// itself.
- dart_sdk.dart.ignoreWhitelistedErrors(whitelist);
+ dart_sdk.dart.ignoreWhitelistedErrors(true);
if (unittest_tests.length == 0) return done();
// TODO(vsm): We're using an old deprecated version of unittest.
@@ -889,6 +889,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
// Restore the Mocha onerror handler in case future tests need to run.
window.onerror = mochaOnError;
this.enableTimeouts(true);
+ dart_sdk.dart.ignoreWhitelistedErrors(false);
let numErrors = countMatches(output, /\d\s+ERROR/g);
let numFails = countMatches(output, /\d\s+FAIL/g);
« no previous file with comments | « no previous file | pkg/dev_compiler/test/browser/runtime_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698