Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3176)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/about_flags.cc

Issue 2789843004: [Payments] Upload card UI now has a CVC prompt (Closed)
Patch Set: Addressing code review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 7b6ea0f4ebe9259d92943574a4b6f413799abb27..af908982a2895972c5b45de5c1211b7456a7a06c 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -2339,6 +2339,17 @@ const FeatureEntry kFeatureEntries[] = {
autofill::kAutofillCreditCardLastUsedDateDisplay,
kAutofillCreditCardLastUsedDateFeatureVariations,
"AutofillCreditCardLastUsedDate")},
+
+#if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) || \
Mathieu 2017/04/03 19:46:09 I don't think you need the ifdef, just kOsDesktop
Jared Saul 2017/04/03 21:19:17 Done.
+ defined(OS_WIN)
+ {"enable-autofill-credit-card-upload-request-cvc-if-missing",
Mathieu 2017/04/03 19:46:09 how about enable-autofill-credit-card-upload-cvc-p
Jared Saul 2017/04/03 21:19:17 Done.
+ flag_descriptions::kAutofillUpstreamRequestCvcIfMissing,
+ flag_descriptions::kAutofillUpstreamRequestCvcIfMissingDescription,
+ kOsDesktop,
+ FEATURE_VALUE_TYPE(autofill::kAutofillUpstreamRequestCvcIfMissing)},
+#endif // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) ||
+ // defined(OS_WIN)
+
#if defined(OS_WIN)
{"windows10-custom-titlebar",
flag_descriptions::kWindows10CustomTitlebarName,
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698