Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: components/autofill/core/browser/ui/save_card_bubble_controller.h

Issue 2789843004: [Payments] Upload card UI now has a CVC prompt (Closed)
Patch Set: Update TestAutofillClient, create MockSaveCardBubbleController, add unit test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/ui/save_card_bubble_controller.h
diff --git a/chrome/browser/ui/autofill/save_card_bubble_controller.h b/components/autofill/core/browser/ui/save_card_bubble_controller.h
similarity index 63%
rename from chrome/browser/ui/autofill/save_card_bubble_controller.h
rename to components/autofill/core/browser/ui/save_card_bubble_controller.h
index 6f74eb3f09414ffee90bbd3e3c8f7bf04c2c129f..2c6561b66bec508f6edbc53ef25c27b21aac05c4 100644
--- a/chrome/browser/ui/autofill/save_card_bubble_controller.h
+++ b/components/autofill/core/browser/ui/save_card_bubble_controller.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_H_
-#define CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_H_
+#ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_UI_SAVE_CARD_BUBBLE_CONTROLLER_H_
+#define COMPONENTS_AUTOFILL_CORE_BROWSER_UI_SAVE_CARD_BUBBLE_CONTROLLER_H_
#include <memory>
#include <vector>
@@ -31,6 +31,20 @@ class SaveCardBubbleController {
// Returns the card that will be uploaded if the user accepts.
virtual const CreditCard GetCard() const = 0;
+ // Returns the CVC image icon resource ID.
+ virtual int GetCvcImageResourceId() const = 0;
+
+ // Returns whether the dialog should include a field requesting the card's CVC
+ // from the user.
+ virtual bool ShouldRequestCvcFromUser() const = 0;
+
+ // Takes in the CVC provided by the user in the save card bubble, to be
+ // populated in the final request.
+ virtual void SetCvcEnteredByUser(const base::string16& cvc) = 0;
+
+ // Returns the CVC provided by the user in the save card bubble.
+ virtual base::string16 GetCvcEnteredByUser() const = 0;
+
// Interaction.
virtual void OnSaveButton() = 0;
virtual void OnCancelButton() = 0;
@@ -43,6 +57,9 @@ class SaveCardBubbleController {
// Returns empty vector if no legal message should be shown.
virtual const LegalMessageLines& GetLegalMessageLines() const = 0;
+ // Utilities.
+ virtual bool InputCvcIsValid(const base::string16& input_text) const = 0;
+
protected:
SaveCardBubbleController() {}
virtual ~SaveCardBubbleController() {}
@@ -52,4 +69,4 @@ class SaveCardBubbleController {
} // namespace autofill
-#endif // CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_H_
+#endif // COMPONENTS_AUTOFILL_CORE_BROWSER_UI_SAVE_CARD_BUBBLE_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698