[Payments] Upload card UI now has a CVC prompt

chrome/browser/ui/cocoa/autofill/save_card_bubble_view_unittest.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <Carbon/Carbon.h>  // For the kVK_* constants.
 
 #include <memory>
 
 #include "base/json/json_reader.h"
 #include "base/values.h"
-#include "chrome/browser/ui/autofill/save_card_bubble_controller.h"
 #import "chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #include "chrome/browser/ui/cocoa/test/cocoa_profile_test.h"
 #include "components/autofill/core/browser/credit_card.h"
+#include "components/autofill/core/browser/ui/save_card_bubble_controller.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #import "ui/events/test/cocoa_test_event_utils.h"
 
 namespace autofill {
 
 namespace {
 
 class TestSaveCardBubbleController : public SaveCardBubbleController {

[groby-ooo-7-16, 2017/04/10 20:41:10]

fwiw: It looks like this is shareable code, not cocoa-specific.

I'm also fairly certain you'd be better off w/ GMOCK  by now :)

[Jared Saul, 2017/04/11 00:53:06]

Yeah, it doesn't look cocoa-specific to me either.  I'll try to investigate this
as a followup if I get some free cycles, thanks.  In the meantime, converted the
blank methods to use GMOCK.

  public:
   TestSaveCardBubbleController() {
     ParseLegalMessageJson();
 
     on_save_button_was_called_ = false;
     on_cancel_button_was_called_ = false;
     on_learn_more_was_called_ = false;
     on_legal_message_was_called_ = false;
     on_bubble_closed_was_called_ = false;
   }
 
   // SaveCardBubbleController:
   base::string16 GetWindowTitle() const override { return base::string16(); }
 
   base::string16 GetExplanatoryMessage() const override {
     return base::string16();
   }
 
   const CreditCard GetCard() const override {
     return CreditCard();
   }
 
+  int GetCvcImageResourceId() const override { return int(); }
+
+  bool ShouldRequestCvcFromUser() const override { return bool(); }
+
+  void SetCvcEnteredByUser(const base::string16& cvc) override {}
+
+  base::string16 GetCvcEnteredByUser() const override {
+    return base::string16();
+  }
+
   void OnSaveButton() override { on_save_button_was_called_ = true; }
   void OnCancelButton() override { on_cancel_button_was_called_ = true; }
   void OnLearnMoreClicked() override { on_learn_more_was_called_ = true; }
   void OnLegalMessageLinkClicked(const GURL& url) override {
     on_legal_message_was_called_ = true;
     legal_message_url_ = url.spec();
   }
   void OnBubbleClosed() override { on_bubble_closed_was_called_ = true; }
 
   const LegalMessageLines& GetLegalMessageLines() const override {
     return lines_;
   }
 
+  bool InputCvcIsValid(const base::string16& input_text) const override {
+    return bool();
+  }
+
   // Testing state.
   bool on_save_button_was_called() { return on_save_button_was_called_; }
   bool on_cancel_button_was_called() { return on_cancel_button_was_called_; }
   bool on_learn_more_was_called() { return on_learn_more_was_called_; }
   bool on_legal_message_was_called() { return on_legal_message_was_called_; }
   std::string legal_message_url() { return legal_message_url_; }
   bool on_bubble_closed_was_called() { return on_bubble_closed_was_called_; }
 
  private:
   void ParseLegalMessageJson() {
@@ skipping 139 matching lines @@
 
 TEST_F(SaveCardBubbleViewTest, EscapeCloses) {
   [[bridge_->view_controller_ window]
       performKeyEquivalent:cocoa_test_event_utils::KeyEventWithKeyCode(
                                kVK_Escape, '\e', NSKeyDown, 0)];
 
   EXPECT_TRUE(bubble_controller_->on_bubble_closed_was_called());
 }
 
 }  // namespace autofill