[Payments] Upload card UI now has a CVC prompt

components/autofill/core/browser/ui/mock_save_card_bubble_controller.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_UI_MOCK_SAVE_CARD_BUBBLE_CONTROLLER_H_
+#define COMPONENTS_AUTOFILL_CORE_BROWSER_UI_MOCK_SAVE_CARD_BUBBLE_CONTROLLER_H_
+
+#include "components/autofill/core/browser/credit_card.h"

[Mathieu, 2017/04/04 23:49:20]

could you fwd declare CreditCard or is this needed because of the MOCK macro?

[Jared Saul, 2017/04/05 00:58:30]

I tried forward declaring it, but the compiler's not happy with it, throwing a
bunch of mock errors and telling me it was already forward-declared in
save_card_bubble_controller.h anyway.

Interestingly, it doesn't work without mocks either.  If I just stub out the
method myself, I get:

error: incomplete result type 'const autofill::CreditCard' in function
definition

+#include "components/autofill/core/browser/ui/save_card_bubble_controller.h"
+#include "testing/gmock/include/gmock/gmock.h"
+
+namespace autofill {
+
+class MockSaveCardBubbleController : public SaveCardBubbleController {
+ public:
+  MockSaveCardBubbleController();
+  ~MockSaveCardBubbleController() override;
+
+  MOCK_CONST_METHOD0(GetWindowTitle, base::string16());
+  MOCK_CONST_METHOD0(GetExplanatoryMessage, base::string16());
+  MOCK_CONST_METHOD0(GetCard, const CreditCard());
+  MOCK_CONST_METHOD0(GetCvcImageResourceId, int());
+  MOCK_CONST_METHOD0(ShouldRequestCvcFromUser, bool());
+  MOCK_METHOD0(OnSaveButton, void());
+  MOCK_METHOD0(OnCancelButton, void());
+  MOCK_METHOD0(OnLearnMoreClicked, void());
+  MOCK_METHOD1(OnLegalMessageLinkClicked, void(const GURL& url));
+  MOCK_METHOD0(OnBubbleClosed, void());
+  MOCK_CONST_METHOD0(GetLegalMessageLines, const LegalMessageLines&());
+  MOCK_CONST_METHOD1(InputCvcIsValid, bool(const base::string16& input_text));
+
+  void SetCvcEnteredByUser(const base::string16& cvc) override;
+  base::string16 GetCvcEnteredByUser() const override;
+
+ private:
+  base::string16 cvc_entered_by_user_;
+
+  DISALLOW_COPY_AND_ASSIGN(MockSaveCardBubbleController);
+};
+
+}  // namespace autofill
+
+#endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_UI_MOCK_SAVE_CARD_BUBBLE_CONTROLLER_H_