Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom

Issue 2789753002: Convert offscreen canvas to use FrameSinkManagerHost. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
diff --git a/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom b/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
index 9626b9d1b395a6cc47e70a15ea28aebf3b579967..d17270b081c7af69886d1ecc99976ec62792cc25 100644
--- a/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
+++ b/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
@@ -4,7 +4,6 @@
module blink.mojom;
-import "cc/ipc/compositor_frame.mojom";
import "cc/ipc/frame_sink_id.mojom";
import "cc/ipc/frame_sink_manager.mojom";
import "cc/ipc/mojo_compositor_frame_sink.mojom";
@@ -16,17 +15,20 @@ interface OffscreenCanvasSurface {
Satisfy(cc.mojom.SurfaceSequence sequence);
};
-interface OffscreenCanvasSurfaceFactory {
+// Creates OffscreenCanvasSurface and MojoCompositorFrameSink instances for use
+// with offscreen canvas.
+interface OffscreenCanvasProvider {
+ // TODO(kylechar): Observer interface shouldn't be FrameSinkManagerClient.
+ // Create an OffscreenCanvasSurface for |frame_sink_id|. |client| will observe
+ // any changes to the SurfaceId associated with |frame_sink_id|.
CreateOffscreenCanvasSurface(cc.mojom.FrameSinkId parent_frame_sink_id,
cc.mojom.FrameSinkId frame_sink_id,
cc.mojom.FrameSinkManagerClient client,
- OffscreenCanvasSurface& service);
-};
+ OffscreenCanvasSurface& surface);
-interface OffscreenCanvasCompositorFrameSinkProvider {
- // TODO(fsamuel, xlai): Replace this with FrameSinkManager
+ // Create an MojoCompositorFrameSink for |frame_sink_id|. This must happen
+ // after creating an OffsreenCanvasSurface for |frame_sink_id|.
CreateCompositorFrameSink(cc.mojom.FrameSinkId frame_sink_id,
cc.mojom.MojoCompositorFrameSinkClient client,
cc.mojom.MojoCompositorFrameSink& sink);
-};
-
+};
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698