third_party/WebKit/LayoutTests/external/wpt/webusb/usbConnectionEvent.https.html - Issue 2789723003: Migrate WebUSB LayoutTests into external/wpt

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/webusb/usbConnectionEvent.https.html

Issue 2789723003: Migrate WebUSB LayoutTests into external/wpt (Closed)

Patch Set: Upstream tests that will work in stable Chrome Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/webusb/resources/usb-helpers.js ('K') | « third_party/WebKit/LayoutTests/external/wpt/webusb/usb-manual.https.html ('k') | third_party/WebKit/LayoutTests/external/wpt/webusb/usbDevice-iframe.https.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="/resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="/resources/testharnessreport.js"></script>

4 <script src="resources/fake-devices.js"></script>	4 <script src="resources/fake-devices.js"></script>

5 <script src="resources/usb-helpers.js"></script>	5 <script src="resources/usb-helpers.js"></script>

6 <script src="resources/webusb-test.js"></script>

7 <script>	6 <script>

8 'use strict';	7 'use strict';

9	8

10 usb_test(() => {	9 usb_test(() => {

11 return getFakeDevice().then(({ device }) => {	10 return getFakeDevice().then(({ device }) => {

12 let evt = new USBConnectionEvent('connect', { device: device });	11 let evt = new USBConnectionEvent('connect', { device: device });

13 assert_equals(evt.type, 'connect');	12 assert_equals(evt.type, 'connect');

14 assert_equals(evt.device, device);	13 assert_equals(evt.device, device);

15 });	14 });

16 }, 'Can construct a USBConnectionEvent with a device');	15 }, 'Can construct a USBConnectionEvent with a device');

17	16

18 test(t => {	17 test(t => {

19 try {	18 try {
	foolip 2017/06/21 08:23:30 Can be reduced to `assert_throws(new TypeError, () Can be reduced to `assert_throws(new TypeError, () => new USBConnectionEvent('connect', { device: null }));` Reilly Grant (use Gerrit) 2017/06/21 21:35:16 Done in https://chromium-review.googlesource.com/c Show quoted text On 2017/06/21 08:23:30, foolip wrote: > Can be reduced to `assert_throws(new TypeError, () => new > USBConnectionEvent('connect', { device: null }));` Done in https://chromium-review.googlesource.com/c/544077/.
20 new USBConnectionEvent('connect', { device: null });	19 new USBConnectionEvent('connect', { device: null });

21 assert_unreached('expected TypeError');	20 assert_unreached('expected TypeError');

22 } catch (err) {	21 } catch (err) {

23 assert_true(err instanceof TypeError);	22 assert_true(err instanceof TypeError);

24 }	23 }

25	24

26 try {	25 try {

27 new USBConnectionEvent('connect', {})	26 new USBConnectionEvent('connect', {})

28 assert_unreached('expected TypeError');	27 assert_unreached('expected TypeError');

29 } catch (err) {	28 } catch (err) {

30 assert_true(err instanceof TypeError);	29 assert_true(err instanceof TypeError);

31 }	30 }

32 }, 'Cannot construct a USBConnectionEvent without a device');	31 }, 'Cannot construct a USBConnectionEvent without a device');

33 </script>	32 </script>

OLD	NEW