Chromium Code Reviews| Index: pkg/dev_compiler/test/browser/language_tests.js |
| diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js |
| index 40be48ad94f2283adb3c181ca919a14298a56386..c11c3058a908aef12a29d4ef3263d1da16e66543 100644 |
| --- a/pkg/dev_compiler/test/browser/language_tests.js |
| +++ b/pkg/dev_compiler/test/browser/language_tests.js |
| @@ -417,9 +417,12 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'], |
| 'custom_elements_23127_test': async_unittest, |
| 'custom_elements_test': async_unittest, |
| - // TODO(jmesserly): investigate the change here; it is likely due to |
| - // different reified types affecting the (gigantic) HTML literal |
| - 'debugger_test': fail, // firefox_fail |
| + // Please do not mark this test as fail. If your change breaks this test, |
| + // copy and paste the gigantic JSON literal shown in the test output |
| + // into debugger_test.dart and then view the diff with your favorite diff |
| + // viewing tool to make sure it looks reasonable. Generally it should be |
| + // fairly obvious if the changes are reasonable or not. |
|
vsm
2017/04/03 15:14:56
Update the comment - perhaps to look at test for i
Jacob
2017/04/03 15:33:05
Done.
|
| + 'debugger_test': firefox_fail, |
| 'element_animate_test': 'unittest', |
| // https://github.com/dart-lang/sdk/issues/27579. |