Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file |
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
| 4 | 4 |
| 5 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'], | 5 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'], |
| 6 function(dart_sdk, async_helper, expect, unittest, is, require) { | 6 function(dart_sdk, async_helper, expect, unittest, is, require) { |
| 7 'use strict'; | 7 'use strict'; |
| 8 | 8 |
| 9 async_helper = async_helper.async_helper; | 9 async_helper = async_helper.async_helper; |
| 10 let minitest = expect.minitest; | 10 let minitest = expect.minitest; |
| (...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 410 | 410 |
| 411 // This is failing with a range error, I'm guessing because it's looking | 411 // This is failing with a range error, I'm guessing because it's looking |
| 412 // for a stylesheet and the page has none. | 412 // for a stylesheet and the page has none. |
| 413 'css_rule_list_test': 'fail', | 413 'css_rule_list_test': 'fail', |
| 414 | 414 |
| 415 'custom_element_method_clash_test': async_unittest, | 415 'custom_element_method_clash_test': async_unittest, |
| 416 'custom_element_name_clash_test': async_unittest, | 416 'custom_element_name_clash_test': async_unittest, |
| 417 'custom_elements_23127_test': async_unittest, | 417 'custom_elements_23127_test': async_unittest, |
| 418 'custom_elements_test': async_unittest, | 418 'custom_elements_test': async_unittest, |
| 419 | 419 |
| 420 // TODO(jmesserly): investigate the change here; it is likely due to | 420 // Please do not mark this test as fail. If your change breaks this test, |
| 421 // different reified types affecting the (gigantic) HTML literal | 421 // copy and paste the gigantic JSON literal shown in the test output |
| 422 'debugger_test': fail, // firefox_fail | 422 // into debugger_test.dart and then view the diff with your favorite diff |
| 423 // viewing tool to make sure it looks reasonable. Generally it should be | |
| 424 // fairly obvious if the changes are reasonable or not. | |
|
vsm
2017/04/03 15:14:56
Update the comment - perhaps to look at test for i
Jacob
2017/04/03 15:33:05
Done.
| |
| 425 'debugger_test': firefox_fail, | |
| 423 'element_animate_test': 'unittest', | 426 'element_animate_test': 'unittest', |
| 424 | 427 |
| 425 // https://github.com/dart-lang/sdk/issues/27579. | 428 // https://github.com/dart-lang/sdk/issues/27579. |
| 426 'element_classes_test': 'fail', | 429 'element_classes_test': 'fail', |
| 427 'element_classes_svg_test': 'fail', | 430 'element_classes_svg_test': 'fail', |
| 428 | 431 |
| 429 // Failure: 'Expected 56 to be in the inclusive range [111, 160].'. | 432 // Failure: 'Expected 56 to be in the inclusive range [111, 160].'. |
| 430 'element_offset_test': 'fail', | 433 'element_offset_test': 'fail', |
| 431 | 434 |
| 432 'element_test': async_unittest, | 435 'element_test': async_unittest, |
| (...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 914 | 917 |
| 915 for (let action of unittest_tests) { | 918 for (let action of unittest_tests) { |
| 916 try { | 919 try { |
| 917 action(); | 920 action(); |
| 918 } catch (e) { | 921 } catch (e) { |
| 919 console.error("Caught error tying to setup test:", e); | 922 console.error("Caught error tying to setup test:", e); |
| 920 } | 923 } |
| 921 } | 924 } |
| 922 }); | 925 }); |
| 923 }); | 926 }); |
| OLD | NEW |