Fix type checks and display for JS interop types.

Fix type checks and display for JS interop types.

Re-enable formatter test that had been disabled when someone changed type
name display for Foo<dynamic> types.
Fix bug in how type names were displayed for JS interop types.

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/509bcd58e133c19d148c43409b47e78f92ce0a45

[Jacob, 2017-03-30 23:46:42]

jacobr@google.com changed reviewers:
+ vsm@google.com

[vsm, 2017-03-31 15:14:08]

https://codereview.chromium.org/2789663005/diff/10001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart (right):

https://codereview.chromium.org/2789663005/diff/10001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart:587: return
isClassSubType(t1, t2._rawJSType, isCovariant);
Depending on where you call this below, it may be safer to call _isSubtype -
e.g., there is no check that t1 is a class type.

https://codereview.chromium.org/2789663005/diff/10001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart:719: if ($t2
instanceof $LazyJSType) {
Can this be dropped to below the "trivial" checks?

Can this interact with FutureOr?  If so, it should probably be dropped below
that too.

https://codereview.chromium.org/2789663005/diff/10001/tests/lib_strong/html/d...
File tests/lib_strong/html/debugger_test.dart (right):

https://codereview.chromium.org/2789663005/diff/10001/tests/lib_strong/html/d...
tests/lib_strong/html/debugger_test.dart:9163: """;
How about putting this literal into a helper file to make it a little easier to
rebase expectations?

Anything else we can do to make it easier to regen that?  Perhaps instead of
dumping the diff, print instructions on what to check / how to reset if ok.

[Jacob, 2017-04-01 00:51:13]

https://codereview.chromium.org/2789663005/diff/10001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart (right):

https://codereview.chromium.org/2789663005/diff/10001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart:587: return
isClassSubType(t1, t2._rawJSType, isCovariant);
On 2017/03/31 15:14:08, vsm wrote:
> Depending on where you call this below, it may be safer to call _isSubtype -
> e.g., there is no check that t1 is a class type.

switched to _isSubtype. Agree that seems safer.

https://codereview.chromium.org/2789663005/diff/10001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart:719: if ($t2
instanceof $LazyJSType) {
On 2017/03/31 15:14:08, vsm wrote:
> Can this be dropped to below the "trivial" checks?
> 
> Can this interact with FutureOr?  If so, it should probably be dropped below
> that too.

Moved down to right before t1 is forced to be a function subtype.

https://codereview.chromium.org/2789663005/diff/10001/tests/lib_strong/html/d...
File tests/lib_strong/html/debugger_test.dart (right):

https://codereview.chromium.org/2789663005/diff/10001/tests/lib_strong/html/d...
tests/lib_strong/html/debugger_test.dart:9163: """;
On 2017/03/31 15:14:08, vsm wrote:
> How about putting this literal into a helper file to make it a little easier
to
> rebase expectations?
> 
> Anything else we can do to make it easier to regen that?  Perhaps instead of
> dumping the diff, print instructions on what to check / how to reset if ok.

Made it a little easier by adding a button to copy to the clipboard. Still not
great but easier. Not that many changes should really be breaking the golden
file.Just contact me if your change breaks it and I'll re-generate. It is pretty
easy now.

https://codereview.chromium.org/2789663005/diff/20001/pkg/dev_compiler/karma....
File pkg/dev_compiler/karma.conf.js (right):

https://codereview.chromium.org/2789663005/diff/20001/pkg/dev_compiler/karma....
pkg/dev_compiler/karma.conf.js:54: '/root_dart/tests/lib/':
'/base/gen/codegen_tests/lib/'
this matches the directory structure used by the regular dart-sdk tests.

[vsm, 2017-04-03 15:14:56]

lgtm

https://codereview.chromium.org/2789663005/diff/20001/pkg/dev_compiler/karma....
File pkg/dev_compiler/karma.conf.js (right):

https://codereview.chromium.org/2789663005/diff/20001/pkg/dev_compiler/karma....
pkg/dev_compiler/karma.conf.js:51: // Proxy requried to match expectations on
where resources required by
requried -> required

https://codereview.chromium.org/2789663005/diff/20001/pkg/dev_compiler/test/b...
File pkg/dev_compiler/test/browser/language_tests.js (right):

https://codereview.chromium.org/2789663005/diff/20001/pkg/dev_compiler/test/b...
pkg/dev_compiler/test/browser/language_tests.js:424: // fairly obvious if the
changes are reasonable or not.
Update the comment - perhaps to look at test for instructions to rebase
expectations?

[Jacob, 2017-04-03 15:33:06]

https://codereview.chromium.org/2789663005/diff/20001/pkg/dev_compiler/karma....
File pkg/dev_compiler/karma.conf.js (right):

https://codereview.chromium.org/2789663005/diff/20001/pkg/dev_compiler/karma....
pkg/dev_compiler/karma.conf.js:51: // Proxy requried to match expectations on
where resources required by
On 2017/04/03 15:14:56, vsm wrote:
> requried -> required

Done.

https://codereview.chromium.org/2789663005/diff/20001/pkg/dev_compiler/test/b...
File pkg/dev_compiler/test/browser/language_tests.js (right):

https://codereview.chromium.org/2789663005/diff/20001/pkg/dev_compiler/test/b...
pkg/dev_compiler/test/browser/language_tests.js:424: // fairly obvious if the
changes are reasonable or not.
On 2017/04/03 15:14:56, vsm wrote:
> Update the comment - perhaps to look at test for instructions to rebase
> expectations?

Done.

[vsm, 2017-04-03 15:33:58]

lgtm

[Jacob, 2017-04-03 15:34:30]

Description was changed from

==========
Fix type checks and display for JS interop types.

Re-enable formatter test that had been disabled when someone changed type
name display for Foo<dynamic> types.
Fix bug in how type names were displayed for JS interop types.

BUG=
==========

to

==========
Fix type checks and display for JS interop types.

Re-enable formatter test that had been disabled when someone changed type
name display for Foo<dynamic> types.
Fix bug in how type names were displayed for JS interop types.

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/509bcd58e133c19d148c43409b47e78f92ce0a45
==========

[Jacob, 2017-04-03 15:34:31]

Committed patchset #4 (id:30001) manually as
509bcd58e133c19d148c43409b47e78f92ce0a45 (presubmit successful).