Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: content/browser/download/download_stats.cc

Issue 2789623005: Add UMA metric to track parallel download requests stats. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_stats.cc
diff --git a/content/browser/download/download_stats.cc b/content/browser/download/download_stats.cc
index 3fcff94ed6e5de4685d2882b858da4f8f7c4e674..eeac14a4ae0553b430e115033d923cf107d1b9d4 100644
--- a/content/browser/download/download_stats.cc
+++ b/content/browser/download/download_stats.cc
@@ -773,6 +773,20 @@ void RecordParallelDownloadCount(DownloadCountTypes type) {
DOWNLOAD_COUNT_TYPES_LAST_ENTRY);
}
+void RecordParallelDownloadRequestCount(int request_count) {
+ UMA_HISTOGRAM_CUSTOM_COUNTS("Download.ParallelDownloadRequestCount",
+ request_count, 1, 10, 10);
Ilya Sherman 2017/03/31 00:33:04 nit: Did you check that this gives you the desired
xingliu 2017/03/31 21:48:26 Done, thanks.
+}
+
+void RecordParallelDownloadEarlyRequests(int request_count) {
+ UMA_HISTOGRAM_CUSTOM_COUNTS("Download.ParallelDownloadEarlyRequestCount",
+ request_count, 1, 10, 10);
+}
+
+void RecordParallelDownloadAddStreamSuccess(bool success) {
+ UMA_HISTOGRAM_BOOLEAN("Download.ParallelDownloadAddStreamSuccess", success);
+}
+
void RecordParallelDownloadStats(
size_t bytes_downloaded_with_parallel_streams,
base::TimeDelta time_with_parallel_streams,

Powered by Google App Engine
This is Rietveld 408576698