Add UMA metric to track parallel download requests stats.

content/browser/download/parallel_download_job.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/parallel_download_job.h"
 
 #include "base/memory/ptr_util.h"
 #include "content/browser/download/download_create_info.h"
+#include "content/browser/download/download_stats.h"
 #include "content/browser/download/parallel_download_utils.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/storage_partition.h"
 
 namespace content {
 namespace {
 
 const int kVerboseLevel = 1;
 
 }  // namespace
 
 ParallelDownloadJob::ParallelDownloadJob(
     DownloadItemImpl* download_item,
     std::unique_ptr<DownloadRequestHandleInterface> request_handle,
     const DownloadCreateInfo& create_info)
     : DownloadJobImpl(download_item, std::move(request_handle)),
       initial_request_offset_(create_info.offset),
-      initial_request_length_(create_info.length),
       content_length_(create_info.total_bytes),
       requests_sent_(false),
       is_canceled_(false) {}
 
 ParallelDownloadJob::~ParallelDownloadJob() = default;
 
 void ParallelDownloadJob::Start() {
   DownloadJobImpl::Start();
 
   BuildParallelRequestAfterDelay();
@@ skipping 58 matching lines @@
 
   timer_.Start(FROM_HERE, GetParallelRequestDelayConfig(), this,
                &ParallelDownloadJob::BuildParallelRequests);
 }
 
 void ParallelDownloadJob::OnByteStreamReady(
     DownloadWorker* worker,
     std::unique_ptr<ByteStreamReader> stream_reader) {
   bool success = DownloadJob::AddByteStream(std::move(stream_reader),
                                             worker->offset(), worker->length());
+  RecordParallelDownloadAddStreamSuccess(success);
 
   // Destroy the request if the sink is gone.
   if (!success) {
     VLOG(kVerboseLevel)
         << "Byte stream arrived after download file is released.";
     worker->Cancel();
   }
 }
 
 void ParallelDownloadJob::OnServerResponseError(
@@ skipping 16 matching lines @@
   // a download is interrupted. This could happen if we use finch to config
   // the number of parallel requests.
   // Get the next |kParallelRequestCount - 1| slices and fork
   // new requests. For the remaining slices, they will be handled once some
   // of the workers finish their job.
   DownloadItem::ReceivedSlices slices_to_download =
       FindSlicesToDownload(download_item_->GetReceivedSlices());
 
   DCHECK(!slices_to_download.empty());
   int64_t first_slice_offset = slices_to_download[0].offset;
-
-  if (initial_request_offset_ > first_slice_offset) {
-    DVLOG(kVerboseLevel) << "Initial request is after the first slice to"
-                            " download.";
-  }
+  DCHECK(initial_request_offset_ <= first_slice_offset);
 
   // Create more slices for a new download. The initial request may generate
-  // a received slice. If there are holes before |initial_request_offset_|,
-  // don't create more slices.
+  // a received slice.
   if (slices_to_download.size() <= 1 &&
-      initial_request_length_ == DownloadSaveInfo::kLengthFullContent &&
       initial_request_offset_ <= first_slice_offset) {
     // TODO(qinmin): Check the size of the last slice. If it is huge, we can
     // split it into N pieces and pass the last N-1 pieces to different workers.
     // Otherwise, just fork |slices_to_download.size()| number of workers.
     slices_to_download = FindSlicesForRemainingContent(
         first_slice_offset,
         content_length_ - first_slice_offset + initial_request_offset_,
         GetParallelRequestCount(), GetMinSliceSize());
   }
 
   DCHECK(!slices_to_download.empty());
   DCHECK_EQ(slices_to_download.back().received_bytes,
             DownloadSaveInfo::kLengthFullContent);
 
   ForkSubRequests(slices_to_download);
+  RecordParallelDownloadRequestCount(
+      static_cast<int>(slices_to_download.size()));
   requests_sent_ = true;
 }
 
 void ParallelDownloadJob::ForkSubRequests(
     const DownloadItem::ReceivedSlices& slices_to_download) {
-  bool initial_request_skipped = false;
-  for (auto it = slices_to_download.begin(); it != slices_to_download.end();
+  if (slices_to_download.size() < 2)
+    return;
+
+  // Assume the first slice to download will be handled by the initial request.
+  for (auto it = slices_to_download.begin() + 1; it != slices_to_download.end();

[qinmin, 2017/04/03 18:36:19]

nit: const auto& it

[xingliu, 2017/04/03 20:38:05]

This will yield compiling error, so does auto& it.

[qinmin, 2017/04/03 20:46:49]

Really? "for (const auto& slice : slices_to_download)" doesn't compile?

        ++it) {
-    // Create requests for holes before the |initial_request_offset_|.
-    if (it->offset < initial_request_offset_) {
-      CreateRequest(it->offset, it->received_bytes);
-      continue;
-    }
-
-    // Assume the first slice to download after |initial_request_offset_| will
-    // be handled by the initial request.
-    if (initial_request_skipped)
-      CreateRequest(it->offset, it->received_bytes);
-    else
-      initial_request_skipped = true;
+    DCHECK(it->offset >= initial_request_offset_);

[David Trainor- moved to gerrit, 2017/04/03 17:59:57]

DCHECK_GE?

[xingliu, 2017/04/03 20:38:05]

Done.

Also replaced a DCHECK with DCHECK_LE in another line. 

+    CreateRequest(it->offset, it->received_bytes);
   }
 }
 
 void ParallelDownloadJob::CreateRequest(int64_t offset, int64_t length) {
   DCHECK(download_item_);
 
   std::unique_ptr<DownloadWorker> worker =
       base::MakeUnique<DownloadWorker>(this, offset, length);
 
   StoragePartition* storage_partition =
@@ skipping 16 matching lines @@
   // download request.
   download_params->set_referrer(Referrer(download_item_->GetReferrerUrl(),
                                          blink::WebReferrerPolicyAlways));
   // Send the request.
   worker->SendRequest(std::move(download_params));
   DCHECK(workers_.find(offset) == workers_.end());
   workers_[offset] = std::move(worker);
 }
 
 }  // namespace content