Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

Issue 2789533003: [SPv2] Stop recording paired display items (except for subsequence markers) (Closed)
Patch Set: none Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/compositing/PaintChunksToCcLayer.h" 5 #include "platform/graphics/compositing/PaintChunksToCcLayer.h"
6 6
7 #include "cc/paint/compositing_display_item.h" 7 #include "cc/paint/compositing_display_item.h"
8 #include "cc/paint/display_item_list.h" 8 #include "cc/paint/display_item_list.h"
9 #include "cc/paint/drawing_display_item.h" 9 #include "cc/paint/drawing_display_item.h"
10 #include "cc/paint/filter_display_item.h" 10 #include "cc/paint/filter_display_item.h"
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 ccList->CreateAndAppendPairedEndItem<cc::EndFilterDisplayItem>(); 174 ccList->CreateAndAppendPairedEndItem<cc::EndFilterDisplayItem>();
175 ccList->CreateAndAppendPairedEndItem<cc::EndCompositingDisplayItem>(); 175 ccList->CreateAndAppendPairedEndItem<cc::EndCompositingDisplayItem>();
176 break; 176 break;
177 } 177 }
178 } 178 }
179 } 179 }
180 180
181 static gfx::Rect largeRect(-200000, -200000, 400000, 400000); 181 static gfx::Rect largeRect(-200000, -200000, 400000, 400000);
182 static void appendDisplayItemToCcDisplayItemList(const DisplayItem& displayItem, 182 static void appendDisplayItemToCcDisplayItemList(const DisplayItem& displayItem,
183 cc::DisplayItemList* list) { 183 cc::DisplayItemList* list) {
184 DCHECK(DisplayItem::isDrawingType(displayItem.getType()) ||
185 displayItem.getType() == DisplayItem::kSubsequence ||
186 displayItem.getType() == DisplayItem::kEndSubsequence);
184 if (DisplayItem::isDrawingType(displayItem.getType())) { 187 if (DisplayItem::isDrawingType(displayItem.getType())) {
185 sk_sp<const PaintRecord> record = 188 sk_sp<const PaintRecord> record =
186 static_cast<const DrawingDisplayItem&>(displayItem).GetPaintRecord(); 189 static_cast<const DrawingDisplayItem&>(displayItem).GetPaintRecord();
187 if (!record) 190 if (!record)
188 return; 191 return;
189 // In theory we would pass the bounds of the record, previously done as: 192 // In theory we would pass the bounds of the record, previously done as:
190 // gfx::Rect bounds = gfx::SkIRectToRect(record->cullRect().roundOut()); 193 // gfx::Rect bounds = gfx::SkIRectToRect(record->cullRect().roundOut());
191 // or use the visual rect directly. However, clip content layers attempt 194 // or use the visual rect directly. However, clip content layers attempt
192 // to raster in a different space than that of the visual rects. We'll be 195 // to raster in a different space than that of the visual rects. We'll be
193 // reworking visual rects further for SPv2, so for now we just pass a 196 // reworking visual rects further for SPv2, so for now we just pass a
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 recordPairedEndDisplayItems(endDisplayItems, ccList.get()); 238 recordPairedEndDisplayItems(endDisplayItems, ccList.get());
236 } 239 }
237 240
238 ccList->CreateAndAppendPairedEndItem<cc::EndTransformDisplayItem>(); 241 ccList->CreateAndAppendPairedEndItem<cc::EndTransformDisplayItem>();
239 242
240 ccList->Finalize(); 243 ccList->Finalize();
241 return ccList; 244 return ccList;
242 } 245 }
243 246
244 } // namespace blink 247 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698