Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5052)

Unified Diff: chrome/browser/resources/inspect/inspect.js

Issue 278953002: DevTools: allow inspecting browsers using custom front-ends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Manually tested end-to-end. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/inspect/inspect.js
diff --git a/chrome/browser/resources/inspect/inspect.js b/chrome/browser/resources/inspect/inspect.js
index 33559673d63575266ef22be4aa5aef40b658bd64..3d6fd7982766a64d815ac33bc0943b5965755136 100644
--- a/chrome/browser/resources/inspect/inspect.js
+++ b/chrome/browser/resources/inspect/inspect.js
@@ -7,6 +7,20 @@ var MIN_VERSION_TARGET_ID = 26;
var MIN_VERSION_NEW_TAB = 29;
var MIN_VERSION_TAB_ACTIVATE = 30;
+var queryParamsObject = {};
+
+(function() {
+var queryParams = window.location.search;
+if (!queryParams)
+ return;
+var params = queryParams.substring(1).split('&');
+for (var i = 0; i < params.length; ++i) {
+ var pair = params[i].split('=');
+ queryParamsObject[pair[0]] = pair[1];
+}
+
+})();
+
function sendCommand(command, args) {
chrome.send(command, Array.prototype.slice.call(arguments, 1));
}
@@ -267,6 +281,18 @@ function populateRemoteTargets(devices) {
browserHeader.appendChild(newPage);
}
+ if (queryParamsObject['browser-inspector']) {
+ var link = document.createElement('span');
+ link.classList.add('action');
+ link.setAttribute('tabindex', 1);
+ link.textContent = 'inspect';
+ browserHeader.appendChild(link);
+ link.addEventListener(
+ 'click',
+ sendCommand.bind(null, 'inspect-browser', browser.source,
+ browser.id, queryParamsObject['browser-inspector']), false);
+ }
+
pageList = document.createElement('div');
pageList.className = 'list pages';
browserSection.appendChild(pageList);

Powered by Google App Engine
This is Rietveld 408576698